From 772c26aa66563fc70d938147b6b56ad535de572f Mon Sep 17 00:00:00 2001 From: Dov Frankel Date: Wed, 14 Apr 2021 23:02:51 -0400 Subject: [PATCH 1/2] Corrected comment --- Classes/UnrarKitMacros.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Classes/UnrarKitMacros.h b/Classes/UnrarKitMacros.h index aea9343..38e466f 100644 --- a/Classes/UnrarKitMacros.h +++ b/Classes/UnrarKitMacros.h @@ -60,7 +60,7 @@ __IPHONE_OS_VERSION_MIN_REQUIRED >= 100000 \ #import // Called from +[UnrarKit initialize] and +[URKArchiveTestCase setUp] -extern os_log_t unrarkit_log; // Declared in URKArchive.m +extern os_log_t unrarkit_log; // Declared in URKArchive.mm extern BOOL unrarkitIsAtLeast10_13SDK; // Declared in URKArchive.m #define URKLogInit() \ unrarkit_log = os_log_create("com.abbey-code.UnrarKit", "General"); \ From e6216ef36051caf999338e2b5dd04de5c5874705 Mon Sep 17 00:00:00 2001 From: Dov Frankel Date: Wed, 14 Apr 2021 23:04:11 -0400 Subject: [PATCH 2/2] Simplified some C code and hopefully fixed a seg fault --- Classes/URKArchive.mm | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/Classes/URKArchive.mm b/Classes/URKArchive.mm index f4ced3d..ae669cc 100644 --- a/Classes/URKArchive.mm +++ b/Classes/URKArchive.mm @@ -1343,9 +1343,7 @@ - (BOOL)_unrarOpenFile:(NSString *)rarFile inMode:(NSInteger)mode withPassword:( URKLogDebug("Setting archive name..."); - const char *filenameData = (const char *) [rarFile UTF8String]; - self.flags->ArcName = new char[strlen(filenameData) + 1]; - strcpy(self.flags->ArcName, filenameData); + self.flags->ArcName = strdup(rarFile.UTF8String); self.flags->OpenMode = (uint)mode; self.flags->OpFlags = self.ignoreCRCMismatches ? ROADOF_KEEPBROKEN : 0;