Key bindings for Layout & Render Style menu...

[georgeraraujo]

... don't make it into TS/translations/ts.pot because of CTRLORALT macro introduced in 5d5ee4a , so rearrange code in src/myframe.h to bring them back.

Closes #809.

[aardappel]

I am not a fan of how much duplication this fix causes, there has to be other ways to make this string translatable without copying everything twice.

Like maybe _(L"Vertical Layout with Grid Style Rendering" "\t" CTRLORALT "+1") so now the string to translate is just the first part?

Or use actual string concatenation.
_(L"Vertical Layout with Grid Style Rendering") + (L"\t" CTRLORALT L"+1") (may need a wxString constructor)

[georgeraraujo]

I don't like it too. I only did it like that because the CTRLORALT macro only gets resolved to CTRL or ALT at compile time. I read the documentation, and as far as I could tell xgettext does not handle this case.

[aardappel]

@tobiolo

[tobiolo]

I am not a fan of how much duplication this fix causes, there has to be other ways to make this string translatable without copying everything twice.

I agree. The costs of the duplicates are too high.

Like maybe _(L"Vertical Layout with Grid Style Rendering" "\t" CTRLORALT "+1") so now the string to translate is just the first part?

Or use actual string concatenation.

_(L"Vertical Layout with Grid Style Rendering") + (L"\t" CTRLORALT L"+1") (may need a wxString constructor)

I would prefer this one. I am unsure whether the first one works but I have not yet tried.

[tobiolo]

Please rebase your translation files against the updated master branch in this repository. Thanks!