Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

There are illegal identifiers: underscore followed by uppercase letter is reserved. #61

Closed
FelixDombek opened this issue Sep 19, 2018 · 1 comment
Closed

There are illegal identifiers: underscore followed by uppercase letter is reserved. #61

FelixDombek opened this issue Sep 19, 2018 · 1 comment

Comments

@FelixDombek
Copy link
Contributor

better-enums uses some identifiers which are not allowed according to the C++ standard. Identifiers beginning with an underscore followed by an uppercase letter are reserved in any namespace (ref). better-enums uses three of those:

  • _Iterable
  • _PutNamesInThisScopeAlso
  • _EnumClassForSwitchStatements

What makes it worse is that these identifiers are not only in library headers, but are inserted into all users' source files via macros. Therefore, code quality checkers flag all sources using better-enums as violating standards.
@FelixDombek FelixDombek mentioned this issue Sep 19, 2018
Merged
@aantron
Copy link
Owner

aantron commented Sep 19, 2018

Fixed by @FelixDombek in #62. Thanks!

@aantron aantron closed this as completed Sep 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@FelixDombek @aantron