storage : fix bug for the testrace of TestSystemZoneConfigs

Fixes cockroachdb#19180. Fixes cockroachdb#19207.
a-robinson · Dec 20, 2017 · 21d4cd9 · 21d4cd9
1 parent 5dded67
commit 21d4cd9
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/pkg/storage/allocator.go b/pkg/storage/allocator.go
@@ -526,7 +526,11 @@ func (a Allocator) RebalanceTarget(
 			StoreID:   target.store.StoreID,
 			ReplicaID: rangeInfo.Desc.NextReplicaID,
 		}
+
+		// Deep-copy the Replicas slice since we'll mutate it.
 		desc := *rangeInfo.Desc
+		desc.Replicas = append([]roachpb.ReplicaDescriptor(nil), desc.Replicas...)
+
 		desc.Replicas = append(desc.Replicas, newReplica)
 		rangeInfo.Desc = &desc