Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix montage view issue in mobile skin #909

Merged
merged 1 commit into from
Jun 26, 2015

Conversation

knight-of-ni
Copy link
Member

Montage view did not work for the mobile skin as reported in this forum post:
http://www.zoneminder.com/forums/viewtopic.php?f=32&t=23236&p=88222

connortechnology added a commit that referenced this pull request Jun 26, 2015
fix montage view issue in mobile skin
@connortechnology connortechnology merged commit e570fdb into ZoneMinder:master Jun 26, 2015
@explanar
Copy link

I my experience the fix does not work as it should: randomly only 50% of the monitors are shown in montage view of mobile skin. (Ubuntu 14.04, ZM 1.28 stable PPA)

The alternative Fix in /includes/function.php: remove ZM_DIR_EVENTS from return( ZM_DIR_EVENTS.'/'.$path );
https://forums.zoneminder.com/viewtopic.php?f=32&t=23236#p88209

works better.

In both cases i don't see Zone Preview Pictures!

@knight-of-ni
Copy link
Member Author

@explanar We are depreciating the mobile skin in favor of using a mobile app, such as zmNinja.
As soon as we release 1.29.0, in the next couple of weeks, we will be deleting the mobile skin from the project. See the 1.29.0 release notes shown on our releases page.

@connortechnology
Copy link
Member

It might be nice to keep it around for really ancient mobile devices.. thinking WinCE devices.

@knight-of-ni
Copy link
Member Author

The removal of the mobile skin was one of a few legacy features slated for removal. It was brought up in #1115 and feedback was asked for at that time. Seeing there were no objections, we moved forward with the plan to remove it and included that in the 1.29.0 release notes.

Similar to the argument that was originally made to consolidate the flat & classic skins into a single folder structure, it doesn't make sense to have a second set of skins living outside this. That creates duplication of effort, requires us to patch multiple folders when skin changes are implemented, etc.

Moving forward, if someone wants to create a new mobile-friendly skin, based on the new way of creating skins through css changes, then that would certainly be a welcome compromise.

@knight-of-ni knight-of-ni deleted the mobile_skin branch December 23, 2016 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants