Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance #3

Open
Zomis opened this issue Sep 15, 2014 · 1 comment
Open

Improve performance #3

Zomis opened this issue Sep 15, 2014 · 1 comment

Comments

@Zomis
Copy link
Owner

Zomis commented Sep 15, 2014

Improve performance. Things that might require refactoring is GroupValues and FieldGroup. GroupValues uses the non-primitive Integer for example, while a good old int would suffice.

@Zomis Zomis changed the title Composition over inheritance Improve performance Dec 14, 2014
@Zomis
Copy link
Owner Author

Zomis commented Jan 4, 2015

GroupValues could possibly use an byte[], where each field is an index in the array. Something like:

  • 0 = unset
  • 1 = field has value 1
  • -1 = field has value 0

All that is needed then is for a good way of connecting a field to an integer. In worst case, this can be done with Map<T, Integer> but I hope for another solution. Perhaps create some Wrapped<T> with the T and an int.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant