Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/structured output #1

Merged
merged 2 commits into from
Jan 16, 2025
Merged

Fix/structured output #1

merged 2 commits into from
Jan 16, 2025

Conversation

Aktsvigun
Copy link
Collaborator

This PR incorporates the response format in the messages when using the structured outputs. It works as follows:

  1. If the json schema itself, or it "prettified" version with json.dumps is already present in the messages, it won't be added again.
  2. Otherwise, if the system message exists, the response format will be added at the end of this message as following:
    system_message = system_message + f"\n\nGenerate the response in the following JSON format:\n{format}"
  3. Otherwise, the response format will be added to the last message.

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@Aktsvigun Aktsvigun requested a review from ZenPuzzle January 15, 2025 16:45
@ZenPuzzle ZenPuzzle merged commit 5574ae0 into v0.6.4.post2 Jan 16, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants