Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reject identity in Group::serialize #667

Closed
doutv opened this issue Jun 5, 2024 · 1 comment · Fixed by #671
Closed

Reject identity in Group::serialize #667

doutv opened this issue Jun 5, 2024 · 1 comment · Fixed by #671
Assignees

Comments

@doutv
Copy link

doutv commented Jun 5, 2024

In current RFC document 3.1, page 10:

SerializeElement(A): Maps an Element A to a canonical byte array
buf of fixed length Ne. This function raises an error if A is the
identity element of the group.

Serialize a Group identity element should raise error.

Related PR:
cfrg/draft-irtf-cfrg-frost#306
#145

@mpguerra mpguerra moved this to Product Backlog in FROST Jun 5, 2024
@mpguerra mpguerra moved this from Product Backlog to New in FROST Jun 5, 2024
@mpguerra mpguerra added this to the FROST v2.0.0 Release milestone Jun 5, 2024
@conradoplg
Copy link
Contributor

Thank you for reporting this! It was good timing since the next release will be an API-breaking one.

@mpguerra mpguerra moved this from New to Review/QA in FROST Jun 11, 2024
@mergify mergify bot closed this as completed in #671 Jun 19, 2024
@github-project-automation github-project-automation bot moved this from Review/QA to Done in FROST Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants