Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use cargo-all-features in CI #631

Closed
conradoplg opened this issue Mar 14, 2024 · 2 comments · Fixed by #659
Closed

Use cargo-all-features in CI #631

conradoplg opened this issue Mar 14, 2024 · 2 comments · Fixed by #659

Comments

@conradoplg
Copy link
Contributor

conradoplg commented Mar 14, 2024 •
edited
Loading

Some issues like #629 and some that I had while writing #535 would be caught by cargo-all-features. We should add to CI unless it takes too long.

This can be as simple as creating a job that installs it and runs cargo build-all-features.
@mpguerra mpguerra moved this to Sprint Backlog in FROST Mar 15, 2024
@mpguerra
Copy link
Contributor

Is this one for @gustavovalverde or can we take care of it within @ZcashFoundation/frost-team ?

@conradoplg
Copy link
Contributor Author

Is this one for @gustavovalverde or can we take care of it within @ZcashFoundation/frost-team ?

It's fairly straightforward, we can take care of it.

@conradoplg conradoplg mentioned this issue May 20, 2024
Merged
@mpguerra mpguerra moved this from Sprint Backlog to In Progress in FROST May 28, 2024
@mpguerra mpguerra moved this from In Progress to Review/QA in FROST Jun 4, 2024
@mergify mergify bot closed this as completed in #659 Jun 4, 2024
@github-project-automation github-project-automation bot moved this from Review/QA to Done in FROST Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
FROST
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: use cargo-all-features ZcashFoundation/frost
2 participants
@conradoplg @mpguerra