Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove frost module #490

Closed
conradoplg opened this issue Aug 19, 2023 · 2 comments · Fixed by #568
Closed

Remove frost module #490

conradoplg opened this issue Aug 19, 2023 · 2 comments · Fixed by #568
Assignees

Comments

@conradoplg
Copy link
Contributor

In frost-core we currently have

  • crate: non-FROST types for signing and verifying
  • crate::frost: FROST types
  • crate::frost::{keys, round1, round2}: the rest

However ciphersuite crates have

  • crate: non-FROST types for signing and verifying, and FROST types
  • crate::{keys, round1, round2}: the rest

Change frost-core to follow the ciphersuite crates, merging crate::frost into crate:: and removing crate::frost and move child modules up accordingly.

This is a significant (though simple) refactoring so we should do this after all open PRs are merged

@hdevalence
Copy link
Contributor

Would this be just moving code around, or changing what's exposed in the public API?

We're working on a FROST implementation here penumbra-zone/decaf377-rdsa#18 and would be happy to track any refactors there, just wondering if we should expect code we're currently using to disappear.

@conradoplg
Copy link
Contributor Author

Would this be just moving code around, or changing what's exposed in the public API?

We're working on a FROST implementation here penumbra-zone/decaf377-rdsa#18 and would be happy to track any refactors there, just wondering if we should expect code we're currently using to disappear.

Just moving things around, basically users of frost-core would need to change imports from e.g. use frost_core::frost::SigningKey to use frost-core::SigningKey. It wouldn't affect ciphersuite crates, just frost-core.

@mpguerra mpguerra added this to FROST Aug 24, 2023
@mpguerra mpguerra moved this to Sprint Backlog in FROST Aug 24, 2023
@mpguerra mpguerra added this to the FROST 1.0.0 Release milestone Sep 6, 2023
@conradoplg conradoplg moved this from Sprint Backlog to In Progress in FROST Oct 31, 2023
@conradoplg conradoplg self-assigned this Oct 31, 2023
@conradoplg conradoplg moved this from In Progress to Review/QA in FROST Oct 31, 2023
@mergify mergify bot closed this as completed in #568 Oct 31, 2023
@github-project-automation github-project-automation bot moved this from Review/QA to Done in FROST Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants