Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Other extensions don't work on the Just Read format #29

Closed
ZachSaucier opened this issue Dec 19, 2016 · 2 comments
Closed

Other extensions don't work on the Just Read format #29

ZachSaucier opened this issue Dec 19, 2016 · 2 comments
Labels

Comments

@ZachSaucier
Copy link
Owner

ZachSaucier commented Dec 19, 2016

Other extensions that run on rendered web pages don't run on the Just Read format. A list of notable extensions that currently have this behavior include:


This is due to Just Read creating and using an <iframe> that uses an about:blank URL, which the other extensions don't usually recognize. For other extensions to work with Just read, they must include "match_about_blank": true to their manifest.json as seen in this thread and manage dynamically created elements.


With that being said, the shared versions of JR pages can support other extensions like any other webpage. See this post for more information.

@ZachSaucier
Copy link
Owner Author

ZachSaucier commented Mar 28, 2018

The only way I could see Just Read modifying itself to be compatible extensions like these is to use an entirely different methodology of attempting to reformat articles to be read, i.e. don't use an <iframe> but attempt to just override every single style for every single element in the article. Due to selector specificity and the wide array of properties that would need to be reset, this is a pretty daunting task to attempt.

If this approach were used, I'd likely have it as a user-selected option and default to use iframes because of the increased reliability in terms of error prevention.

Edit: I tried using the shadow DOM instead of iframes instead of iframes and it fixed this issue. However, it is incompatible with some Premium features so I can't use that approach. See #282 for more info.

@ZachSaucier
Copy link
Owner Author

Just Read Premium now supports any other extensions in its shared version of Just Read Pages. See this post for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant