Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arduino Nano 33 IoT Not Compatible #56

Closed
1 task done
Tracked by #61
Speshl opened this issue Dec 26, 2023 · 1 comment · Fixed by #57
Closed
1 task done
Tracked by #61

Arduino Nano 33 IoT Not Compatible #56

Speshl opened this issue Dec 26, 2023 · 1 comment · Fixed by #57
Assignees
Labels
🐞 Bug 🐞 OH DEAR!!! You seem to have spotted a bug! ...in progress 🚧 Development on this is in progress

Comments

@Speshl
Copy link
Contributor

Speshl commented Dec 26, 2023

Is there an existing issue for this bug?

  • I have searched the issues and there is no existing issue for this bug.

What development environment are you using?

Arduino IDE

What board are you using?

Arduino Nano 33 IoT

What part of CRSF for Arduino is this bug related to?

Compatibility Table

Current behaviour

With the debug flag enabled. I get the following when calling crsf.begin()

[Serial Receiver | INFO]: Initialising... 
[Compatibility Table | DEBUG]: Board is Incompatible device
incompatible.
Incompatible device

[Serial Receiver | ERROR]: Devboard is not compatible.

Expected behaviour

Expected crsf to begin.

Steps to reproduce

Issue can be reproduced with the channels example.

Additional information

Attempting to log the name that it is comparing against shows the name as empty.

    bool CompatibilityTable::isDevboardCompatible(const char *name)
    {
        // Debug.
        // Serial.print("[Compatibility Table | DEBUG]: Board is ");

        if (strcmp(name, deviceNames[DEVBOARD_IS_INCOMPATIBLE]) == 0)
        {
            // Debug.
            Serial.println("incompatible.");
            Serial.println(name);

            return false;
        }

        else
        {
            // Debug.
            // Serial.println("compatible.");

            return true;
        }

        // return strcmp(name, deviceNames[DEVBOARD_IS_INCOMPATIBLE]) != 0 ? true : false;
    }
@Speshl Speshl added Pending 📌 This is waiting for me to check it out 🐞 Bug 🐞 OH DEAR!!! You seem to have spotted a bug! labels Dec 26, 2023
@Speshl
Copy link
Contributor Author

Speshl commented Dec 26, 2023

Added below to compatibility table and got past initialization.

#elif USB_PID == 0x8057
        device.type.devboard = DEVBOARD_ARDUINO_NANO_33_IOT;

@ZZ-Cat ZZ-Cat self-assigned this Dec 27, 2023
@ZZ-Cat ZZ-Cat added this to the Version 1.0.0 milestone Dec 27, 2023
@ZZ-Cat ZZ-Cat added ...in progress 🚧 Development on this is in progress and removed Pending 📌 This is waiting for me to check it out labels Dec 27, 2023
@ZZ-Cat ZZ-Cat moved this to Todo in Development Schedule Dec 27, 2023
@ZZ-Cat ZZ-Cat moved this from Todo to In Progress in Development Schedule Jan 4, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Development Schedule Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 Bug 🐞 OH DEAR!!! You seem to have spotted a bug! ...in progress 🚧 Development on this is in progress
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants