Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

C++23 compatibility #7196

Closed
NikolajBjorner opened this issue Apr 1, 2024 · 1 comment
Closed

C++23 compatibility #7196

NikolajBjorner opened this issue Apr 1, 2024 · 1 comment
Assignees
@nunoplopes

Comments

@NikolajBjorner
Copy link
Contributor

std::aligned_storage is deprecated in newer versions of C++.

typename std::aligned_storage<sizeof(T), alignof(T)>::type m_initial_buffer[INITIAL_SIZE];

https://github.com/Z3Prover/z3/blob/84092cbd96a1d4c65bea6db2370807b19519704e/src/util/buffer.h#L33C5-L33C95

What is the correct change (to alignas(T)...)?
@waywardmonkeys
Copy link
Contributor

This is addressed in https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2021/p1413r3.pdf which suggests using alignas(T) std::byte buf[...], but with some caveats and discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nunoplopes nunoplopes

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@waywardmonkeys @nunoplopes @NikolajBjorner