From 08134b9f6b0873a81b0a76ceabe6751efb48e102 Mon Sep 17 00:00:00 2001 From: Xuan Wang Date: Thu, 7 Dec 2023 13:06:02 -0800 Subject: [PATCH] [Python Misc] Revert change to print backtrace in server (#34877) Fix: https://github.com/grpc/grpc/issues/34853 In order to make debugging easier, we have begun printing backtraces in servers. However, this change has the unintended consequence of printing errors to stderr by default, which may not be expected by some users. This PR reverts the change. We recommend that users set up a logging sink if they want to see errors. We will add this to our documentation later. Closes #34877 COPYBARA_INTEGRATE_REVIEW=https://github.com/grpc/grpc/pull/34877 from XuanWang-Amos:revert_print_backtrace_change 8942308784b253fa6ae3f1a7dd03e4f89719cb30 PiperOrigin-RevId: 588885550 --- src/python/grpcio/grpc/_server.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/python/grpcio/grpc/_server.py b/src/python/grpcio/grpc/_server.py index 595056136b766..4ea1d5e459784 100644 --- a/src/python/grpcio/grpc/_server.py +++ b/src/python/grpcio/grpc/_server.py @@ -579,7 +579,7 @@ def _call_behavior( exception.__traceback__, ) ) - traceback.print_exc() + traceback.print_exc() _LOGGER.exception(details) _abort( state,