Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tray icon breaks xpra attach on gnome 3.12 #681

Closed
totaam opened this issue Sep 14, 2014 · 20 comments
Closed

tray icon breaks xpra attach on gnome 3.12 #681

totaam opened this issue Sep 14, 2014 · 20 comments

Comments

@totaam
Copy link
Collaborator

totaam commented Sep 14, 2014

Issue migrated from trac ticket # 681

component: client | priority: minor | resolution: fixed

2014-09-14 16:43:34: pyther created the issue


Operating System: Fedora 20
Xpra 0.14.6

This error does not occur on ArchLinux with Xpra 0.14.6.

$ ssh attach ssh:[email protected]:301
2014-09-14 11:35:30,023 xpra client version 0.14.6
** Message: pygobject_register_sinkfunc is deprecated (GstObject)
2014-09-14 11:35:30,324 OpenGL_accelerate module loaded
2014-09-14 11:35:30,324 Using accelerated ArrayDatatype
2014-09-14 11:35:30,325 OpenGL support could not be enabled:
2014-09-14 11:35:30,325  The texture size is too small: 8192
2014-09-14 11:35:30,498 detected keyboard: rules=evdev, model=pc104, layout=us
2014-09-14 11:35:30,499 desktop size is 5680x1440 with 1 screen(s):
2014-09-14 11:35:30,499   ':0.0' (1503x381 mm) workarea: 5680x1413 at 0x27
2014-09-14 11:35:30,499     eDP1 2560x1440 (310x174 mm)
2014-09-14 11:35:30,499     DP3 1680x1050 at 2560x0 (474x296 mm)
2014-09-14 11:35:30,499     DP4 1440x900 at 4240x0 (408x255 mm)
****************************************************************************
                          NOTICE TO USERS
****************************************************************************
Error in atexit._run_exitfuncs:
Traceback (most recent call last):
  File "/usr/lib64/python2.6/atexit.py", line 24, in _run_exitfuncs
    func(*targs, **kargs)
  File "/usr/lib64/python2.6/logging/__init__.py", line 1516, in shutdown
    h.flush()
  File "/usr/lib64/python2.6/logging/__init__.py", line 762, in flush
    self.stream.flush()
ValueError: I/O operation on closed file
Error in sys.exitfunc:
Traceback (most recent call last):
  File "/usr/lib64/python2.6/atexit.py", line 24, in _run_exitfuncs
    func(*targs, **kargs)
  File "/usr/lib64/python2.6/logging/__init__.py", line 1516, in shutdown
    h.flush()
  File "/usr/lib64/python2.6/logging/__init__.py", line 762, in flush
    self.stream.flush()
ValueError: I/O operation on closed file
2014-09-14 11:36:39,523 The SSH process has terminated with exit code 0
2014-09-14 11:36:39,524 Connection to the xpra server via SSH failed for: ssh:[email protected]:301
2014-09-14 11:36:39,524  the command line used was: ['ssh', '-l', 'pyther', '-T', 'host.example.com', 'xpra initenv >> /dev/null 2>&1 || echo "Warning: xpra server does not support initenv" 1>&2;~/.xpra/run-xpra _proxy :301']
2014-09-14 11:36:39,525  check your username, hostname, display number, etc
2014-09-14 11:36:39,525 internal error: read connection TwoFileConnection(ssh:[email protected]:301) closed: cannot read using ['ssh', '-l', 'pyther', '-T', 'host.example.com', 'xpra initenv >> /dev/null 2>&1 || echo "Warning: xpra server does not support initenv" 1>&2;~/.xpra/run-xpra _proxy :301']: the SSH process has terminated with exit code=0
@totaam
Copy link
Collaborator Author

totaam commented Sep 14, 2014

2014-09-14 18:08:13: pyther changed title from xpra fails to attach on fedora20 ValueError to tray icon breaks xpra attach on gnome 3.12

@totaam
Copy link
Collaborator Author

totaam commented Sep 14, 2014

2014-09-14 18:08:13: pyther commented


This appears to be an issue with the tray icon. Running with --no-tray allows xpra to start without a problem.

Running Fedora 20 with Gnome 3.12. I have not followed gnome development but in 3.12 you can right click on system tray icon (from the message center) and it gives you the right click menu. I don't think this was the cause with older versions of gnome.

@totaam
Copy link
Collaborator Author

totaam commented Sep 15, 2014

2014-09-15 02:02:22: pyther commented


I think #657 might be related. Also found this Debian mailing list which seems to describe the same issue. https://www.mail-archive.com/[email protected]/msg1250201.html

@totaam
Copy link
Collaborator Author

totaam commented Sep 15, 2014

2014-09-15 10:58:25: totaam changed owner from antoine to pyther

@totaam
Copy link
Collaborator Author

totaam commented Sep 15, 2014

2014-09-15 10:58:25: totaam edited the issue description

@totaam
Copy link
Collaborator Author

totaam commented Sep 15, 2014

2014-09-15 10:58:25: totaam commented


I am unable to reproduce this with a clean Fedora 20 virtual machine, or with my local dev box. (or with Debian as per #657)

Can you please try to give me something easier to reproduce or at least narrow it down a bit: is SSH required for reproducing the bug? does this happen if you connect locally? (no ssh or tcp) if not, does it happen using TCP mode?
Does it occur with an Arch client? Arch server? Or just Fedora clients with any server type?
What about ssh to localhost?
Does it happen everytime, or most of the time? etc..

@totaam
Copy link
Collaborator Author

totaam commented Sep 15, 2014

2014-09-15 11:15:24: pyther commented


I believe this is an issue with gnome 3.12. I am using gnome 3.12 on Fedora 20 from the rhughes f20-gnome-3-12 copr repository [1].

I do not use gnome on Arch, but I suspect the problem would be reproducible if I did.

The problem is always reproducible. It occurs when attaching to a local and a remote server. It also occurs when using TCP or SSH. From what I can tell this is certainly a client issue and is unrelated to the version running on the server.

Running with '--no-tray' always allows xpra to work.

(1) https://copr.fedoraproject.org/coprs/rhughes/f20-gnome-3-12/

@totaam
Copy link
Collaborator Author

totaam commented Sep 15, 2014

2014-09-15 11:31:13: totaam changed priority from major to minor

@totaam
Copy link
Collaborator Author

totaam commented Sep 15, 2014

2014-09-15 11:31:13: totaam changed status from new to assigned

@totaam
Copy link
Collaborator Author

totaam commented Sep 15, 2014

2014-09-15 11:31:13: totaam changed owner from pyther to totaam

@totaam
Copy link
Collaborator Author

totaam commented Sep 15, 2014

2014-09-15 11:31:13: totaam commented


I quote: It contains packages built automatically that have had very little testing.

I'm not saying there isn't a bug in xpra... but at this point, I can't spend too much time installing unstable bits to cause problems, I've got enough problems already!

I'll test when I get a chance.

@totaam
Copy link
Collaborator Author

totaam commented Sep 16, 2014

2014-09-16 04:50:06: totaam commented


Confirmed in a VM with gnome 3.12 from the repo above.

Interesting (and annoying) data point: whilst still running the old gnome with the new libraries installed, xpra still worked ok (xpra was running against the libraries then..).
Which means that the problem is likely to be gnome-side, and much harder to figure out.

@totaam
Copy link
Collaborator Author

totaam commented Sep 16, 2014

2014-09-16 15:55:07: totaam commented


Got something interesting: --delay-tray also fixes things.

I think it has something to do with us creating the tray widget before the main loop is running.

@totaam
Copy link
Collaborator Author

totaam commented Sep 16, 2014

2014-09-16 16:08:06: totaam commented


Fixed in r7641. Will backport.

@pyther: does that fix things for you?

@totaam
Copy link
Collaborator Author

totaam commented Sep 16, 2014

2014-09-16 16:29:07: totaam changed status from assigned to new

@totaam
Copy link
Collaborator Author

totaam commented Sep 16, 2014

2014-09-16 16:29:07: totaam changed owner from totaam to pyther

@totaam
Copy link
Collaborator Author

totaam commented Sep 17, 2014

2014-09-17 01:57:36: pyther commented


Applied the patch on top of 0.14.6, it solves the problem. Thanks!

@totaam
Copy link
Collaborator Author

totaam commented Sep 17, 2014

2014-09-17 04:28:33: totaam changed status from new to closed

@totaam
Copy link
Collaborator Author

totaam commented Sep 17, 2014

2014-09-17 04:28:33: totaam changed resolution from ** to fixed

@totaam
Copy link
Collaborator Author

totaam commented Sep 17, 2014

2014-09-17 04:28:33: totaam commented


Backport in 7653. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant