Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hyper/tcp leads to compilation issues on WebAssembly #366

Closed
j178 opened this issue May 17, 2023 · 3 comments · Fixed by #591
Closed

hyper/tcp leads to compilation issues on WebAssembly #366

j178 opened this issue May 17, 2023 · 3 comments · Fixed by #591
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@j178
Copy link

j178 commented May 17, 2023

Hi,

octocrab enables hyper/tcp by default, it uses socket2, which does not compile on wasm. I am unsure about the necessity of enabling hyper/tcp. Is it possible to remove or find an alternative for it to resolve the compilation issue?

@XAMPPRocky
Copy link
Owner

Thank you for your issue! This is something I want to address, but right now I'm not sure of the best way to resolve it I think ideally this library would be HTTP client agnostic to avoid this situation, and that's the solution I'd like to pursue long term, but right now I'm not sure how to achieve that yet.

@XAMPPRocky XAMPPRocky added enhancement New feature or request help wanted Extra attention is needed labels May 22, 2023
@patrickelectric
Copy link

patrickelectric commented Aug 26, 2023

looking forward for this feature!
Did you check https://crates.io/crates/octocrab_wasi ?
I got it compiling under wasm32-wasi, but does not have the latest features of this repo.

@XAMPPRocky
Copy link
Owner

@patrickelectric Yes, the problem with that crate is that it uses reqwest which means it's even more incompatible with the rest of the HTTP ecosystem even though it provides wasi support. It's unfortunate that two crates by the same author are so incompatible with each other, but that's the current state of the world. Ideally you'd be able to pass in a reqwest::Client to be able to achieve the same result as that fork, but you currently cannot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants