Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Creator: TypeError when inserting Classic block #35

Closed
iandunn opened this issue Jan 19, 2021 · 3 comments
Closed

Creator: TypeError when inserting Classic block #35

iandunn opened this issue Jan 19, 2021 · 3 comments
Assignees
@ryelle
Labels
[Component] Pattern Creator Anything related to the pattern front end editor or preview [Type] Bug Something isn't working

Comments

@iandunn
Copy link
Member

iandunn commented Jan 19, 2021

I get TypeError: can't access property "tinymce", window.wpEditorL10n is undefined when trying to insert the Classic block
@iandunn iandunn added [Type] Bug Something isn't working [Component] Pattern Creator Anything related to the pattern front end editor or preview labels Jan 19, 2021
@ryelle
Copy link
Contributor

ryelle commented Jan 26, 2021

What do you think about disallowing the Classic block? If the goal of a pattern directory is to show cool things you can do with blocks, allowing the Classic block seems counterproductive.

@iandunn
Copy link
Member Author

iandunn commented Jan 26, 2021

That works for me 👍🏻

@ryelle ryelle mentioned this issue Feb 3, 2021
Merged
@ryelle ryelle self-assigned this Feb 4, 2021
@ryelle
Copy link
Contributor

ryelle commented Feb 4, 2021

The classic block was removed in 14ce49c

@ryelle ryelle closed this as completed Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ryelle ryelle

Labels
[Component] Pattern Creator Anything related to the pattern front end editor or preview [Type] Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@iandunn @ryelle