Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single result page modal behavior #640

Open
zackkrida opened this issue Dec 3, 2021 · 5 comments
Open

Single result page modal behavior #640

zackkrida opened this issue Dec 3, 2021 · 5 comments
Labels
🕹 aspect: interface Concerns end-users' experience with the software ✨ goal: improvement Improvement to an existing user-facing feature 🟩 priority: low Low priority and doesn't need to be rushed 🧱 stack: frontend Related to the Nuxt frontend

Comments

@zackkrida
Copy link
Member

zackkrida commented Dec 3, 2021

Description

Single result pages will be styled as modals when navigated to from the search results view, but will be full-width pages when visited server-side, direct from a shared url, for example. You can observe this behavior on Unsplash by searching for an image, viewing the result, and then refreshing the page:

CleanShot.2021-12-03.at.11.28.15-converted.mp4
@zackkrida zackkrida added 🟩 priority: low Low priority and doesn't need to be rushed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work ✨ goal: improvement Improvement to an existing user-facing feature 💻 aspect: code Concerns the software code in the repository 🕹 aspect: interface Concerns end-users' experience with the software 🟨 priority: medium Not blocking but should be addressed soon 💬 talk: discussion Open for discussions and feedback and removed 🟩 priority: low Low priority and doesn't need to be rushed 💻 aspect: code Concerns the software code in the repository 💬 talk: discussion Open for discussions and feedback labels Dec 3, 2021
@fcoveram fcoveram self-assigned this Dec 14, 2021
@fcoveram
Copy link
Contributor

I have been playing with different ideas, and here is the version I like most for both single result views.

CleanShot 2021-12-14 at 15 36 22@2x

Header ideas

For the header, I tried a more prominent search bar, an expanded internal menu, and hiding the search result controls (content switcher + filters) since both are content-related. But I also tried showing the openverse logo (symbol + name) as thinking of users opening an Openverse link without knowing the tool. In that scenario, adding the openverse name would help with adding more context.

That being said, the header used in mockups has a full-width grid of Modal L, as introduced in ticket WordPress/openverse-frontend#522.

Header ideas

@fcoveram
Copy link
Contributor

fcoveram commented Dec 14, 2021

Regarding Full size M audio component, I tested different widths and background colors.

Audio component versions

A full-width grid with a gray background version looks centered and balanced, but when playing it, the yellow background will look odd since it does not start from the far-left beginning.

CleanShot 2021-12-14 at 15 57 10@2x

A full-width grid with white background version looks clean and it blends greatly with the header. However, by consistency, the image single result page looks floating and empty due to white space on the sides. Plus the yellow background problem when playing the audio.

CleanShot 2021-12-14 at 15 57 27@2x

Finally, a full-width page with white background also looks beautiful by the blending effect, and it works well with showing the yellow background. But it has the consistency problem with the image single result view.

CleanShot 2021-12-14 at 16 00 21@2x

@fcoveram
Copy link
Contributor

fcoveram commented Jan 4, 2022

I updated the Releases file with the mockups, and the Design Library with a new variant of the header component: Header. Modal.

@zackkrida
Copy link
Member Author

The simplest way to do this off the top of my head:

When navigating to a single result from the search result pages, display the single audio/image view in a modal and update the url without re-routing. When single result links are visited directly, continue the same behavior we have now of showing them as standalone pages.

@sarayourfriend sarayourfriend self-assigned this Jan 13, 2022
@zackkrida zackkrida added 🟩 priority: low Low priority and doesn't need to be rushed and removed 🟨 priority: medium Not blocking but should be addressed soon labels Jan 21, 2022
@krysal krysal removed the 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work label Mar 8, 2022
@obulat obulat mentioned this issue Feb 18, 2023
2 tasks
@obulat obulat transferred this issue from WordPress/openverse-frontend Feb 22, 2023
@obulat obulat added the 🧱 stack: frontend Related to the Nuxt frontend label Feb 22, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Openverse Backlog Feb 23, 2023
@obulat obulat added the ⛔ status: blocked Blocked & therefore, not ready for work label Jun 6, 2023
@obulat
Copy link
Contributor

obulat commented Jun 6, 2023

This issue is blocked by the Nuxt 3 migration.

@obulat obulat removed the ⛔ status: blocked Blocked & therefore, not ready for work label Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🕹 aspect: interface Concerns end-users' experience with the software ✨ goal: improvement Improvement to an existing user-facing feature 🟩 priority: low Low priority and doesn't need to be rushed 🧱 stack: frontend Related to the Nuxt frontend
Projects
Status: 📋 Backlog
Development

No branches or pull requests

5 participants