From accb302064d14d05675bb6c99e5b9674e7040dd8 Mon Sep 17 00:00:00 2001
From: Jarda Snajdr <jsnajdr@gmail.com>
Date: Mon, 18 Nov 2024 15:20:45 +0100
Subject: [PATCH] PostTitle: exit early when post type doesn't support titles
---
.../editor/src/components/post-title/index.js | 36 ++++++++++---------
1 file changed, 19 insertions(+), 17 deletions(-)
diff --git a/packages/editor/src/components/post-title/index.js b/packages/editor/src/components/post-title/index.js
index 50595d936b36d9..7fc79eaeddffb5 100644
--- a/packages/editor/src/components/post-title/index.js
+++ b/packages/editor/src/components/post-title/index.js
@@ -28,7 +28,7 @@ import usePostTitleFocus from './use-post-title-focus';
import usePostTitle from './use-post-title';
import PostTypeSupportCheck from '../post-type-support-check';
-function PostTitle( _, forwardedRef ) {
+const PostTitle = forwardRef( ( _, forwardedRef ) => {
const { placeholder } = useSelect( ( select ) => {
const { getSettings } = select( blockEditorStore );
const { titlePlaceholder } = getSettings();
@@ -171,23 +171,21 @@ function PostTitle( _, forwardedRef ) {
return (
/* eslint-disable jsx-a11y/heading-has-content, jsx-a11y/no-noninteractive-element-to-interactive-role */
- <PostTypeSupportCheck supportKeys="title">
- <h1
- ref={ useMergeRefs( [ richTextRef, focusRef ] ) }
- contentEditable
- className={ className }
- aria-label={ decodedPlaceholder }
- role="textbox"
- aria-multiline="true"
- onFocus={ onSelect }
- onBlur={ onUnselect }
- onKeyDown={ onKeyDown }
- onPaste={ onPaste }
- />
- </PostTypeSupportCheck>
+ <h1
+ ref={ useMergeRefs( [ richTextRef, focusRef ] ) }
+ contentEditable
+ className={ className }
+ aria-label={ decodedPlaceholder }
+ role="textbox"
+ aria-multiline="true"
+ onFocus={ onSelect }
+ onBlur={ onUnselect }
+ onKeyDown={ onKeyDown }
+ onPaste={ onPaste }
+ />
/* eslint-enable jsx-a11y/heading-has-content, jsx-a11y/no-noninteractive-element-to-interactive-role */
);
-}
+} );
/**
* Renders the `PostTitle` component.
@@ -197,4 +195,8 @@ function PostTitle( _, forwardedRef ) {
*
* @return {Component} The rendered PostTitle component.
*/
-export default forwardRef( PostTitle );
+export default forwardRef( ( _, forwardedRef ) => (
+ <PostTypeSupportCheck supportKeys="title">
+ <PostTitle ref={ forwardedRef } />
+ </PostTypeSupportCheck>
+) );