From 9a716bfe9dca474a538f3f38318ac9a3a33da9bb Mon Sep 17 00:00:00 2001 From: Andrea Fercia Date: Thu, 14 Nov 2024 14:54:24 +0100 Subject: [PATCH 1/2] Fix Choose menu label when a menu has been deleted. --- .../src/navigation/edit/navigation-menu-selector.js | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/packages/block-library/src/navigation/edit/navigation-menu-selector.js b/packages/block-library/src/navigation/edit/navigation-menu-selector.js index dceabf063b26e..92fb63185031e 100644 --- a/packages/block-library/src/navigation/edit/navigation-menu-selector.js +++ b/packages/block-library/src/navigation/edit/navigation-menu-selector.js @@ -61,6 +61,7 @@ function NavigationMenuSelector( { hasResolvedNavigationMenus, canUserCreateNavigationMenus, canSwitchNavigationMenu, + isNavigationMenuMissing, } = useNavigationMenu(); const [ currentTitle ] = useEntityProp( @@ -106,12 +107,18 @@ function NavigationMenuSelector( { const noBlockMenus = ! hasNavigationMenus && hasResolvedNavigationMenus; const menuUnavailable = hasResolvedNavigationMenus && currentMenuId === null; + const navMenuHasBeenDeleted = currentMenuId && isNavigationMenuMissing; let selectorLabel = ''; if ( isResolvingNavigationMenus ) { selectorLabel = __( 'Loading…' ); - } else if ( noMenuSelected || noBlockMenus || menuUnavailable ) { + } else if ( + noMenuSelected || + noBlockMenus || + menuUnavailable || + navMenuHasBeenDeleted + ) { // Note: classic Menus may be available. selectorLabel = __( 'Choose or create a Navigation Menu' ); } else { From 3fa33878bde8856d5740b06c3d4362ff6a4c709d Mon Sep 17 00:00:00 2001 From: Andrea Fercia Date: Thu, 14 Nov 2024 16:23:01 +0100 Subject: [PATCH 2/2] Pass menu ID to useNavigationMenu. --- .../src/navigation/edit/navigation-menu-selector.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/block-library/src/navigation/edit/navigation-menu-selector.js b/packages/block-library/src/navigation/edit/navigation-menu-selector.js index 92fb63185031e..0efb597ff8532 100644 --- a/packages/block-library/src/navigation/edit/navigation-menu-selector.js +++ b/packages/block-library/src/navigation/edit/navigation-menu-selector.js @@ -62,7 +62,7 @@ function NavigationMenuSelector( { canUserCreateNavigationMenus, canSwitchNavigationMenu, isNavigationMenuMissing, - } = useNavigationMenu(); + } = useNavigationMenu( currentMenuId ); const [ currentTitle ] = useEntityProp( 'postType',