From 31d3e279d250c48403420f71d7a8b3d024d7533c Mon Sep 17 00:00:00 2001 From: Ryan Welcher Date: Thu, 20 Jul 2023 12:25:10 -0400 Subject: [PATCH 1/8] Move the example property in block.json. --- .../block-templates/index.js.mustache | 8 -------- packages/create-block-interactive-template/index.js | 7 +++++++ 2 files changed, 7 insertions(+), 8 deletions(-) diff --git a/packages/create-block-interactive-template/block-templates/index.js.mustache b/packages/create-block-interactive-template/block-templates/index.js.mustache index cf40358217c76..5279d80f5754c 100644 --- a/packages/create-block-interactive-template/block-templates/index.js.mustache +++ b/packages/create-block-interactive-template/block-templates/index.js.mustache @@ -28,14 +28,6 @@ import metadata from './block.json'; * @see https://developer.wordpress.org/block-editor/developers/block-api/#registering-a-block */ registerBlockType( metadata.name, { - /** - * Used to construct a preview for the block to be shown in the block inserter. - */ - example: { - attributes: { - message: '{{title}}', - }, - }, /** * @see ./edit.js */ diff --git a/packages/create-block-interactive-template/index.js b/packages/create-block-interactive-template/index.js index a52475ed7a79e..4d2913a0b2ad5 100644 --- a/packages/create-block-interactive-template/index.js +++ b/packages/create-block-interactive-template/index.js @@ -15,6 +15,13 @@ module.exports = { }, render: 'file:./render.php', viewScript: 'file:./view.js', + customBlockJSON: { + example: { + attributes: { + message: 'Example Interactive', + }, + }, + }, }, variants: { basic: {}, From 5b383360235b2c9803f7b55b6d933adebd948b68 Mon Sep 17 00:00:00 2001 From: Ryan Welcher Date: Thu, 20 Jul 2023 12:27:03 -0400 Subject: [PATCH 2/8] Add late escaping to the render.php file. --- .../block-templates/render.php.mustache | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/packages/create-block-interactive-template/block-templates/render.php.mustache b/packages/create-block-interactive-template/block-templates/render.php.mustache index ba791783e6ede..c791b43f56d51 100644 --- a/packages/create-block-interactive-template/block-templates/render.php.mustache +++ b/packages/create-block-interactive-template/block-templates/render.php.mustache @@ -8,7 +8,7 @@ $unique_id = uniqid( 'p-' ); ?>
+ data-wp-interactive data-wp-context='{ "{{namespace}}": { "isOpen": false } }' data-wp-effect="effects.{{namespace}}.logIsOpen" @@ -16,18 +16,18 @@ $unique_id = uniqid( 'p-' );

-{{/isBasicVariant}} \ No newline at end of file +{{/isBasicVariant}} From e193d4a3245a191e829e8cef93abb0912bd4b6a5 Mon Sep 17 00:00:00 2001 From: Ryan Welcher Date: Thu, 20 Jul 2023 12:34:39 -0400 Subject: [PATCH 3/8] Fix type cho -> echo in render file. --- .../block-templates/render.php.mustache | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/create-block-interactive-template/block-templates/render.php.mustache b/packages/create-block-interactive-template/block-templates/render.php.mustache index c791b43f56d51..4791783ad18ce 100644 --- a/packages/create-block-interactive-template/block-templates/render.php.mustache +++ b/packages/create-block-interactive-template/block-templates/render.php.mustache @@ -16,7 +16,7 @@ $unique_id = uniqid( 'p-' ); From 6ce4e3b81165e0fd777d453c478e3b9ac6da63d9 Mon Sep 17 00:00:00 2001 From: Ryan Welcher Date: Thu, 20 Jul 2023 12:51:42 -0400 Subject: [PATCH 4/8] Add doc block to the render.php file. --- .../block-templates/render.php.mustache | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/packages/create-block-interactive-template/block-templates/render.php.mustache b/packages/create-block-interactive-template/block-templates/render.php.mustache index 4791783ad18ce..048f590ba8302 100644 --- a/packages/create-block-interactive-template/block-templates/render.php.mustache +++ b/packages/create-block-interactive-template/block-templates/render.php.mustache @@ -1,6 +1,13 @@ {{#isBasicVariant}} Date: Thu, 20 Jul 2023 13:20:02 -0400 Subject: [PATCH 5/8] Remove escaping for get_block_wrapper_attributes --- .../block-templates/render.php.mustache | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/create-block-interactive-template/block-templates/render.php.mustache b/packages/create-block-interactive-template/block-templates/render.php.mustache index 048f590ba8302..c458473d565e0 100644 --- a/packages/create-block-interactive-template/block-templates/render.php.mustache +++ b/packages/create-block-interactive-template/block-templates/render.php.mustache @@ -15,7 +15,7 @@ $unique_id = uniqid( 'p-' ); ?>
+ data-wp-interactive data-wp-context='{ "{{namespace}}": { "isOpen": false } }' data-wp-effect="effects.{{namespace}}.logIsOpen" From cdbd6838c8ef3944d57491841e1cc7721bb25c9b Mon Sep 17 00:00:00 2001 From: Ryan Welcher Date: Thu, 20 Jul 2023 13:23:41 -0400 Subject: [PATCH 6/8] Define an empty example property to trigger the inserter preview. --- packages/create-block-interactive-template/index.js | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/packages/create-block-interactive-template/index.js b/packages/create-block-interactive-template/index.js index 4d2913a0b2ad5..688874306ce41 100644 --- a/packages/create-block-interactive-template/index.js +++ b/packages/create-block-interactive-template/index.js @@ -16,11 +16,7 @@ module.exports = { render: 'file:./render.php', viewScript: 'file:./view.js', customBlockJSON: { - example: { - attributes: { - message: 'Example Interactive', - }, - }, + example: {}, }, }, variants: { From 06d208a2b87004e1ea398f7d5488ec79ce604b97 Mon Sep 17 00:00:00 2001 From: Ryan Welcher Date: Thu, 20 Jul 2023 13:43:13 -0400 Subject: [PATCH 7/8] Move example to top level based on #52803 --- packages/create-block-interactive-template/index.js | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/packages/create-block-interactive-template/index.js b/packages/create-block-interactive-template/index.js index 688874306ce41..5717b3e709723 100644 --- a/packages/create-block-interactive-template/index.js +++ b/packages/create-block-interactive-template/index.js @@ -15,9 +15,7 @@ module.exports = { }, render: 'file:./render.php', viewScript: 'file:./view.js', - customBlockJSON: { - example: {}, - }, + example: {}, }, variants: { basic: {}, From 562926189ad45c510d3822d2f40a3fe00a42ca81 Mon Sep 17 00:00:00 2001 From: Ryan Welcher Date: Mon, 24 Jul 2023 09:47:29 -0400 Subject: [PATCH 8/8] Add changelog entry. --- packages/create-block-interactive-template/CHANGELOG.md | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/packages/create-block-interactive-template/CHANGELOG.md b/packages/create-block-interactive-template/CHANGELOG.md index a79948001de14..b2a9c87e57f26 100644 --- a/packages/create-block-interactive-template/CHANGELOG.md +++ b/packages/create-block-interactive-template/CHANGELOG.md @@ -1 +1,7 @@ + +## Unreleased + +### Enhancement + +- Moves the `example` property into block.json by leveraging changes to create-block to now support `example`. [#52801](https://github.com/WordPress/gutenberg/pull/52801)