From 9ff1aa7571f5dbe9b4186e9f640a06a4e38b3347 Mon Sep 17 00:00:00 2001 From: Nate Wright Date: Tue, 11 Dec 2018 11:40:00 +0000 Subject: [PATCH 1/2] Add attributes to ServerSideRender readme Adds a code example demonstrating how to define attributes when registering a block that will use attributes in a ServerSideRender component. --- .../src/server-side-render/README.md | 24 +++++++++++++++++-- 1 file changed, 22 insertions(+), 2 deletions(-) diff --git a/packages/components/src/server-side-render/README.md b/packages/components/src/server-side-render/README.md index ee18a7f4294ed6..fb52ee8ab96731 100644 --- a/packages/components/src/server-side-render/README.md +++ b/packages/components/src/server-side-render/README.md @@ -32,5 +32,25 @@ Output uses the block's `render_callback` function, set when defining the block. ## API Endpoint -The API endpoint for getting the output for ServerSideRender is `/wp/v2/block-renderer/:block`. It accepts any params, which are used as `attributes` for the block's `render_callback` method. - +The API endpoint for getting the output for ServerSideRender is `/wp/v2/block-renderer/:block`. It will use the block's `render_callback` method. + +If you pass `attributes` to ServerSideRender you must define these attributes when registering the block. + +```php +register_block_type( + 'core/archives', + array( + 'attributes' => array( + 'showPostCounts' => array( + 'type' => 'boolean', + 'default' => false, + ), + 'displayAsDropdown' => array( + 'type' => 'boolean', + 'default' => false, + ), + ), + 'render_callback' => 'render_block_core_archives', + ) +); +``` From f68792ad90534afa1940cc16511fb9b90192717d Mon Sep 17 00:00:00 2001 From: Nate Wright Date: Tue, 11 Dec 2018 14:56:20 +0000 Subject: [PATCH 2/2] Add whitespace and inline code markup to ServerSideRender readme Implements requested changes from code review. --- .../components/src/server-side-render/README.md | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/packages/components/src/server-side-render/README.md b/packages/components/src/server-side-render/README.md index fb52ee8ab96731..55b0be7630dabb 100644 --- a/packages/components/src/server-side-render/README.md +++ b/packages/components/src/server-side-render/README.md @@ -34,20 +34,20 @@ Output uses the block's `render_callback` function, set when defining the block. The API endpoint for getting the output for ServerSideRender is `/wp/v2/block-renderer/:block`. It will use the block's `render_callback` method. -If you pass `attributes` to ServerSideRender you must define these attributes when registering the block. +If you pass `attributes` to `ServerSideRender`, the block must also be registered and have its attributes defined in PHP. ```php register_block_type( 'core/archives', array( - 'attributes' => array( - 'showPostCounts' => array( - 'type' => 'boolean', - 'default' => false, + 'attributes' => array( + 'showPostCounts' => array( + 'type' => 'boolean', + 'default' => false, ), 'displayAsDropdown' => array( - 'type' => 'boolean', - 'default' => false, + 'type' => 'boolean', + 'default' => false, ), ), 'render_callback' => 'render_block_core_archives',