eslint rule for object property shorthand/object-shorthand

[tofumatt]

Looks like we don't have an eslint rule around object-shorthand, as discovered in #7941 (comment). We do use it in the code in some places, I like it, so I'd advocate we use it anytime we can.

We should just make a rule around it. I'd prefer we enforce using it whenever possible ("always"), but I mainly don't like it being unclear.

[huntlisa]

Picking this up as my first ever open source issue. 🤞

[gziolo]

As commented in #18123 (comment)

It looks like object-shorthand is already set up in the WordPress plugin for ESLint:

gutenberg/packages/eslint-plugin/configs/esnext.js

Line 26 in af9ea75

'object-shorthand': 'error',

I was surprised seeing no errors reported and that's why I double-checked. I don't think we should override it for the Gutenberg specific config. We can simply close the parent issue. Sorry about that. Thank you for helping with closing the open issue though 🙇

@GeckoLisa - thanks for your help!