Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Components: increase the helpText.fontSize #69467

Open
2 of 6 tasks
afercia opened this issue Mar 6, 2025 · 3 comments · May be fixed by #69468
Open
2 of 6 tasks

Components: increase the helpText.fontSize #69467

afercia opened this issue Mar 6, 2025 · 3 comments · May be fixed by #69468
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Needs Design Feedback Needs general design feedback. [Package] Components /packages/components [Type] Bug An existing feature does not function as intended

Comments

@afercia
Copy link
Contributor

afercia commented Mar 6, 2025

Description

Splitting this out from #69451 (comment)

In #69451 the Visibility panel in the pre-publish checks has been refactored and now uses RadioControl which uses a 12 pixels font size for the help text.

'helpText.fontSize': '12px',

The previous font size was 13 pixels. As such, the help text is now smaller and it's actually a reduced legibility level.

Overall, I'd think there should't be any text in the editor that uses a font size smaller than 13 pixels.
12 pixels is really too small in 2025. I'd even consider to raise any minimum font size to at least 14 pixels but for now 13px would be a good start.

Of course, I do understand the help text must have, in a way, slightly less prominence. However, typography hierarchy doesn't necessarily need to use the font size. It can be provided by color, spacing, white space and the like.

CC @WordPress/gutenberg-components and @WordPress/gutenberg-design

Step-by-step reproduction instructions

N/A

Screenshot to illustrate an example of help text with a 12 pixels font size (on the right) compared with the previous 13 pixels font size (on the left). Please ignore the different alignments / spacings and only focus on the help text font size.

Image

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

  • Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

  • Yes

Please confirm which theme type you used for testing.

  • Block
  • Classic
  • Hybrid (e.g. classic with theme.json)
  • Not sure
@afercia afercia added [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Package] Components /packages/components [Type] Bug An existing feature does not function as intended Needs Design Feedback Needs general design feedback. labels Mar 6, 2025
@code-with-mehedi code-with-mehedi linked a pull request Mar 6, 2025 that will close this issue
@Mamaduka
Copy link
Member

Mamaduka commented Mar 6, 2025

Thanks for creating an issue, @afercia!

@ciampo
Copy link
Contributor

ciampo commented Mar 6, 2025

Nothing to say against larger font size in general, although we should be aware of the implications of changing the variable:

  • there may be design implications (especially about type hierarchy and spacing) that may be considered a design regressions, and would therefore require other design adjustments to allow for the font size change
  • let's make sure to update, in case, any corresponding sass variables across the repo (likely in the base scss styles files)
  • let's make sure to check the consequences everywhere the variable is used

@afercia
Copy link
Contributor Author

afercia commented Mar 7, 2025

I'd agree on all points and this is definitely an effort I'd love to see establishing new typography system guidelines across all WordPress.
Cc @WordPress/gutenberg-design

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). Needs Design Feedback Needs general design feedback. [Package] Components /packages/components [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants