-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include Non-synced Patterns' title/name in the Inserter list (synced patterns' names/titles are included) #67243
Comments
Thanks for the report. I believe that in the current pattern list, user-created patterns have a visual title, while theme-provided patterns have the title displayed as a tooltip: Admittedly, it's confusing that titles are displayed differently depending on the pattern. In my opinion, there are two approaches:
cc @WordPress/gutenberg-design @ntsekouras |
I'm drawn to display the title of every pattern. I can't think of a reason why hiding some. |
Ditto. I'm working on a flow where the patterns look visually similar, but the real difference is in their use case and content. Descriptive names would make it easier for consumers to find the patterns they need. |
Thank you all for your feedback. In fact, the pattern list displayed in the inserter is a component called Should we display a visual title in all of these places as well? Zoom Out mode: Change designUser patterns have visual titles, while theme-provided patterns do not. Template Parts Block: Design TabTemplate : Design Tab |
As Aki illustrates these lists are reused quite a bit. This should be considered and factored in at the component level. See: #66549 |
I was briefly troubleshooting this again and confirmed that this only occurs if you make your pattern in your theme's PHP folder. If you make the pattern through the site editor, the pattern's title will appear in the inserter. additional ref 10up/gutenberg-best-practices#161 |
What problem does this address?
I am not sure if this behavior is intentional but I've been asked by my co-workers who are content editors why the names of synced patterns are included but non-synced patterns' names are omitted in the list of available patterns in the block inserter.
In the screenshot below, there are 3 synced patterns - each of their names are listed; and the indicator that they are synced with the purple symbol is very helpful) first; then the non-synced patterns are listed without their names.
UPDATE: Non-synced Patterns' names are only omitted if the pattern is created in a php file. Non-synced Patterns that are created through the site editor will have their names appear in the inserter list.
At the least, It is confusing and inconsistent that synced patterns' titles are included but the names of non-synced patterns are omitted in this list.
What is your proposed solution?
Ideally, include the names of non-synced patterns in the list.
The text was updated successfully, but these errors were encountered: