Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patterns in the inserter re-render on click of blocks in the editor #66052

Closed
2 tasks done
madhusudhand opened this issue Oct 11, 2024 · 3 comments
Closed
2 tasks done
Assignees
Labels
[Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced [Feature] Zoom Out [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@madhusudhand
Copy link
Member

Description

Patterns are re-rendered every-time the active block changes in the editor.

Image

Step-by-step reproduction instructions

  • Open editor
  • Open pattern menu
  • Click on block in the editor and observe patterns getting re-rendered

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

  • Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

  • Yes
@madhusudhand madhusudhand added the [Type] Bug An existing feature does not function as intended label Oct 11, 2024
@madhusudhand madhusudhand self-assigned this Oct 11, 2024
@madhusudhand madhusudhand added [Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced [Feature] Zoom Out labels Oct 11, 2024
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Oct 11, 2024
@ndiego
Copy link
Member

ndiego commented Oct 11, 2024

This is the same issue reported here: #65920, but since this one is already being worked on, @madhusudhand, it's up to you which one to close. I am going to add this to the 6.7 project board regardless.

@ndiego ndiego moved this to 📥 Todo in WordPress 6.7 Editor Tasks Oct 11, 2024
@ndiego ndiego moved this from 📥 Todo to 🏗️ In Progress in WordPress 6.7 Editor Tasks Oct 11, 2024
@ndiego
Copy link
Member

ndiego commented Oct 11, 2024

#65833 is also related to this issue.

@madhusudhand
Copy link
Member Author

Closing duplicate of #65920

@github-project-automation github-project-automation bot moved this from 🏗️ In Progress to ✅ Done in WordPress 6.7 Editor Tasks Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Patterns A collection of blocks that can be synced (previously reusable blocks) or unsynced [Feature] Zoom Out [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
Status: Done
Development

No branches or pull requests

2 participants