Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve duplicate preloading of REST API index #6539

Closed
danielbachhuber opened this issue May 2, 2018 · 1 comment
Closed

Resolve duplicate preloading of REST API index #6539

danielbachhuber opened this issue May 2, 2018 · 1 comment
Assignees
@desrosj
Labels
REST API Interaction Related to REST API [Type] Code Quality Issues or PRs that relate to code quality [Type] Enhancement A suggestion for improvement.
Milestone
WordPress 5.0 RC

Comments

@danielbachhuber
Copy link
Member

In #6434, we began loading / into the default store. However, the REST API index is also loaded into wpApiSettings.schema.

In the interest of not repeating ourselves, we should only load this data once. We have at least a couple of options:

  1. Prime the default store based off wpApiSettings.schema, instead of making the sec
  2. Create a read-only /wp/v2/themes/current endpoint, move theme_supports data into that response, and use it instead.
@danielbachhuber danielbachhuber added the REST API Interaction Related to REST API label May 2, 2018
@danielbachhuber danielbachhuber added this to the WordPress 5.0 milestone May 2, 2018
@danielbachhuber danielbachhuber mentioned this issue May 2, 2018
Merged
@gziolo gziolo mentioned this issue Jun 7, 2018
Merged
@danielbachhuber danielbachhuber added the [Type] Enhancement A suggestion for improvement. label Oct 1, 2018
@mtias mtias added the [Type] Code Quality Issues or PRs that relate to code quality label Oct 12, 2018
@danielbachhuber
Copy link
Member Author

I can't find wpApiSettings.schema anymore, so looks like this was sorted out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@desrosj desrosj

Labels
REST API Interaction Related to REST API [Type] Code Quality Issues or PRs that relate to code quality [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
WordPress 5.0 RC
Development

No branches or pull requests
3 participants
@danielbachhuber @desrosj @mtias