-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Global padding not applied in the template part editor #59742
Comments
I agree, that the padding is missing is confusing to me too when I am working with the template parts in "isolation". I was told that this is intentional. I'm not sure if I can find the conversation, if I do stumble upon it again I will add a link here. |
I agree - this is the exact reason why I think this current implementation is not developer-, designer-, or user-friendly. It's a deceptive experince while working on theme design.
Thanks - I would think the reasoning is about that the template part editor should display content and styles used strictly in the part design, while global padding is, well, global, so it should be displayed in the larger context only, which is the template, not some of its parts (even if the global padding is practically applied only on a container element of a template part). Personally, I would partially agree with such reasoning, but overall, I would also vote against it because this is a theory vs. practice/experience type of topic, and, as the purpose of the whole Full Site Editing paradigm is providing site owners with an easy-to-use and easy-to-learn site editor and site editing experience - and this easy-to-misinterpret experience definitely goes against the principle. |
Hey folks! Here's the discussion if I have it correct: #51937 I've removed the bug label for now. |
I agree. The discrepancy in appearance between the site editor and the template part editor doesn't make sense to me, even though it's technically correct. I assume it doesn't make sense to the vast majority of users too. In my opinion, it should appear identically in both editors. |
Description
The global padding feature, when
useRootPaddingAwareAlignments
is set totrue
in thetheme.json
file, is not working properly in the site editor:has-global-padding
class is applied correctly, but the class styles are missing.Template editor => header with horizontal paddings displayed correctly
Template part editor => header with horizontal paddings displayed incorrectly
Step-by-step reproduction instructions
layout.type = constrained
div (directly following alayout.type = flow
div, or one withoutlayout.type
specification) in a template partstyles.spacing.padding
values in thetheme.json
fileScreenshots, screen recording, code snippet
No response
Environment info
No response
Please confirm that you have searched existing issues in the repo.
Yes
Please confirm that you have tested with all plugins deactivated except Gutenberg.
Yes
The text was updated successfully, but these errors were encountered: