Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data views: Table headers are no longer sticky #58977

Closed
jameskoster opened this issue Feb 13, 2024 · 4 comments · Fixed by #59467
Closed

Data views: Table headers are no longer sticky #58977

jameskoster opened this issue Feb 13, 2024 · 4 comments · Fixed by #59467
Assignees
Labels
[Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release

Comments

@jameskoster
Copy link
Contributor

Most likely due to the addition of wrappers like .dataviews-wrapper and .dataviews-view-table-wrapper, table column headers are no longer sticking to the top of the container as you scroll.

Given the additional nesting we may need to use javascript to handle this.

@jameskoster jameskoster added [Type] Regression Related to a regression in the latest release [Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond labels Feb 13, 2024
@annezazu annezazu moved this to 📥 Todo in WordPress 6.5 Editor Tasks Feb 13, 2024
@jameskoster jameskoster added the [Type] Bug An existing feature does not function as intended label Feb 23, 2024
@jameskoster
Copy link
Contributor Author

Adding Bug label since the current code is effectively broken. If we can't restore this functionality for 6.5 then we should at least remove the broken code.

@annezazu
Copy link
Contributor

@ntsekouras tagging you on this for a 6.5 fix!

@ntsekouras
Copy link
Contributor

ntsekouras commented Feb 29, 2024

The style responsible for this comes from here: #57930

and specifically from:

.dataviews-view-table-wrapper {
	overflow-x: auto;
}

I've tried a few things to make it work, but without success so far. I'll keep looking a bit more, but some folks with more css expertize could be more helpful.

@jameskoster
Copy link
Contributor Author

I have a potential fix, will open a PR.

@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Feb 29, 2024
@github-project-automation github-project-automation bot moved this from 📥 Todo to ✅ Done in WordPress 6.5 Editor Tasks Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended [Type] Regression Related to a regression in the latest release
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants