Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataViews] When we hide fields from the columns in table view, there is a focus loss #57341

Closed
andrewhayward opened this issue Dec 22, 2023 · 0 comments · Fixed by #57340
Closed

[DataViews] When we hide fields from the columns in table view, there is a focus loss #57341

andrewhayward opened this issue Dec 22, 2023 · 0 comments · Fixed by #57340
Labels
[Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes).

Comments

@andrewhayward
Copy link
Contributor

andrewhayward commented Dec 22, 2023 •
edited
Loading

When columns are hidden from the column header menu, the menu is necessarily removed from the DOM, which leaves focus at the whim of the user agent. We need to be intentional about focus movement in this case.

Additionally, there are others areas of interaction that can lead to focus loss. When tables are sorted, filtered, or paginated, new data can be fetched. If this takes time to come back, the header is currently replaced with a "no results" message, until the fetch is complete.
This was referenced Dec 22, 2023
Open
Merged
@andrewhayward andrewhayward changed the title When we hide fields from the columns in table view, there is a focus loss [DataViews] When we hide fields from the columns in table view, there is a focus loss Dec 22, 2023
@annezazu annezazu added [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond labels Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] DataViews Work surrounding upgrading and evolving views in the site editor and beyond [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes).
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Dataviews] Table layout: Ensure focus is not lost on interaction WordPress/gutenberg
2 participants
@andrewhayward @annezazu