Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alignment controls should also be in Inspector Controls #56198

Open
getdave opened this issue Nov 16, 2023 · 3 comments
Open

Alignment controls should also be in Inspector Controls #56198

getdave opened this issue Nov 16, 2023 · 3 comments
Labels
[Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Feature] Inspector Controls The interface showing block settings and the controls available for each block Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.

Comments

@getdave
Copy link
Contributor

getdave commented Nov 16, 2023

Currently blocks that support alignment only have that control in the block toolbar. This is often confusing for users. Many of the layout-type controls are in the Inspector Controls and so they learn the pattern to look there for layout controls but then suddently a key layout control isn't available there.

We should consider have the alignment control in both. This happens for other controls such as Duotone.

Screen Shot 2023-11-16 at 10 19 37
@getdave getdave added [Type] Enhancement A suggestion for improvement. Needs Design Feedback Needs general design feedback. [Feature] Inspector Controls The interface showing block settings and the controls available for each block [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi labels Nov 16, 2023
@hanneslsm
Copy link

In #55993 @culturerich pointed something out that I really like (because I always knew there was something off with the toolbar but could't say what) and that we might take into consideration:

Many times users assumed the block toolbar was a shortcuts toolbar

This is also relevant for the search block, social icons and the query loop. We have settings (styling, font sizes, number of posts) in the toolbar that one would expect in the sidebar.

@getdave
Copy link
Contributor Author

getdave commented Nov 16, 2023

I know @richtabor had thoughts about where various options should reside in the UI.

Whatever we do we need a clear standard that applies consistently across all Core blocks.

@richtabor
Copy link
Member

I think it's fine to include alignment/width controls in the inspector block-wide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Feature] Inspector Controls The interface showing block settings and the controls available for each block Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

3 participants