Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search Block: Remove unused buttonBehavior attribute #53435

Closed
t-hamano opened this issue Aug 8, 2023 · 0 comments · Fixed by #53467
Closed

Search Block: Remove unused buttonBehavior attribute #53435

t-hamano opened this issue Aug 8, 2023 · 0 comments · Fixed by #53467
Labels
[Block] Search Affects the Search Block - used to display a search field [Type] Code Quality Issues or PRs that relate to code quality

Comments

@t-hamano
Copy link
Contributor

t-hamano commented Aug 8, 2023 •
edited
Loading

"Button only" style has been added to the Search block by #50487. At the same time, a new buttonBehavior attribute has been added. However, this attribute is not changed by setAttributes(), it only has a default value. Therefore, it should be safe to remove this attribute by itself and this attribute in the conditional statement.
@t-hamano t-hamano added [Type] Code Quality Issues or PRs that relate to code quality [Block] Search Affects the Search Block - used to display a search field labels Aug 8, 2023
@t-hamano t-hamano mentioned this issue Aug 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Block] Search Affects the Search Block - used to display a search field [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Search Block: Remove unused buttonBehavior attribute WordPress/gutenberg
1 participant
@t-hamano