Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Site Editor Pages: If the Posts Page is set, load the appropriate template, not the empty page. #52114

Closed
jameskoster opened this issue Jun 29, 2023 · 4 comments · Fixed by #52266
Closed

Site Editor Pages: If the Posts Page is set, load the appropriate template, not the empty page. #52114

jameskoster opened this issue Jun 29, 2023 · 4 comments · Fixed by #52266
Assignees
@ramonjd
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Bug An existing feature does not function as intended

Comments

@jameskoster
Copy link
Contributor

jameskoster commented Jun 29, 2023 •
edited
Loading

Currently: opening the Posts Page via the Pages panel in the Site Editor loads the data from that page into the details panel:

Screenshot 2023-06-29 at 12 20 07

It's not very practical because this 'page' always resolves to display a specific template (Home or Index), and that template doesn't actually display any page data. It also breaks the word count / time to read data points (#51260).

Clicking to edit this page takes you to an awkward state where nothing on the canvas can be edited until you engage template editing.

We can resolve this by updating the Posts Page menu item to link directly to the relevant template.

Screenshot 2023-06-29 at 12 25 13
@jameskoster jameskoster converted this from a draft issue Jun 29, 2023
@jameskoster jameskoster moved this from Needs issue or PR to Needs dev in 6.3 Design Jun 29, 2023
@jameskoster jameskoster changed the title If you have a static page set as “Home” or “Blog”, load the appropriate template into the frame, not the empty page. Site Editor Pages: If the Posts Page is set, load the appropriate template into the frame, not the empty page. Jun 29, 2023
@jameskoster jameskoster added [Type] Enhancement A suggestion for improvement. [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels Jun 29, 2023
@ndiego
Copy link
Member

ndiego commented Jun 29, 2023

@jameskoster do you think this could be considered a bug, i.e. something we need to get fixed for 6.3?

@jameskoster
Copy link
Contributor Author

Ideally, yes.

@ndiego ndiego moved this to ❓ Triage in WordPress 6.3.x Editor Tasks Jun 29, 2023
@priethor priethor moved this to Needs development in Polish Jun 30, 2023
@ndiego ndiego added [Type] Bug An existing feature does not function as intended and removed [Type] Enhancement A suggestion for improvement. labels Jul 3, 2023
@ndiego ndiego moved this from ❓ Triage to 📥 Todo in WordPress 6.3.x Editor Tasks Jul 3, 2023
@ramonjd
Copy link
Member

ramonjd commented Jul 4, 2023

I can look at this

@ramonjd ramonjd moved this from 📥 Todo to 🏗️ In Progress in WordPress 6.3.x Editor Tasks Jul 4, 2023
@ramonjd ramonjd mentioned this issue Jul 4, 2023
Merged
@ramonjd ramonjd moved this from 🏗️ In Progress to 🔎 Needs Review in WordPress 6.3.x Editor Tasks Jul 4, 2023
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Jul 4, 2023
@ramonjd
Copy link
Member

ramonjd commented Jul 4, 2023

Hopefully have something working over here:

@priethor priethor moved this from Needs development to In progress in Polish Jul 4, 2023
@jameskoster jameskoster changed the title Site Editor Pages: If the Posts Page is set, load the appropriate template into the frame, not the empty page. Site Editor Pages: If the Posts Page is set, load the appropriate template, not the empty page. Jul 5, 2023
@github-project-automation github-project-automation bot moved this from 🔎 Needs Review to ✅ Done in WordPress 6.3.x Editor Tasks Jul 10, 2023
@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label Jul 10, 2023
@priethor priethor moved this from In progress to Done in Polish Jul 10, 2023
@jameskoster jameskoster moved this from Needs dev to Done in 6.3 Design Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ramonjd ramonjd

Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Type] Bug An existing feature does not function as intended
Projects
6.3 Design
Status: Done
Polish
Status: Done
WordPress 6.3.x Editor Tasks
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Site Editor Pages: load the appropriate template if posts page set WordPress/gutenberg
4 participants
@jameskoster @ndiego @ramonjd @priethor