Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Site Logo: add width unit support (percentage, viewport units, etc) #49281

Open
Tracked by #33447
annezazu opened this issue Mar 22, 2023 · 4 comments
Open
Tracked by #33447

Site Logo: add width unit support (percentage, viewport units, etc) #49281

annezazu opened this issue Mar 22, 2023 · 4 comments
Labels
[Block] Site Logo Affects the Site Logo Block [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi Needs Dev Ready for, and needs developer efforts [Type] Enhancement A suggestion for improvement.

Comments

@annezazu
Copy link
Contributor

Compared to other blocks, the site logo doesn't have the same width unit support (percentage, viewport units, etc). Related issue around how the site logo block has a "width" option when inside a row block: #47979

Pulled from: #48443

Marking as needs dev since I imagine this is related to block supports.
@annezazu annezazu added Needs Dev Ready for, and needs developer efforts [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Block] Site Logo Affects the Site Logo Block labels Mar 22, 2023
@annezazu annezazu moved this to 💻 Needs development in Gutenberg Phase 2: Customization Mar 22, 2023
@annezazu annezazu mentioned this issue Mar 22, 2023
Open
30 tasks
@carolinan carolinan assigned carolinan and unassigned carolinan Mar 28, 2023
@jordesign jordesign added the [Type] Enhancement A suggestion for improvement. label Jul 26, 2023
@mtias mtias mentioned this issue Aug 2, 2023
Open
65 tasks
@annezazu annezazu moved this to Needs Dev / Todo in WordPress 6.4 Editor Tasks Aug 30, 2023
@richtabor
Copy link
Member

Do users want logos displaying at variable widths though? Site title yes, but I’m not sure I’ve seen a logo with that effect before.

@bph bph moved this from Needs Dev / Todo to Punted to 6.5 in WordPress 6.4 Editor Tasks Sep 18, 2023
@bph bph moved this to ❓ Triage in WordPress 6.5 Editor Tasks Nov 23, 2023
@annezazu
Copy link
Contributor Author

annezazu commented Feb 8, 2024

After a review by core editor triage leads and core editor tech leads, this has been removed from the board for 6.5 consideration.

@carolinan
Copy link
Contributor

Do users want logos displaying at variable widths though? Site title yes, but I’m not sure I’ve seen a logo with that effect before.

Probably not.

What people may want is to have a small logo on mobile and a larger (wider) on desktop, but the ability to change the unit is not quiet a replacement for that.

@akasunil
Copy link
Member

Units like percentages could be helpful for responsive design ensuring the design adapts well across different screen sizes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Block] Site Logo Affects the Site Logo Block [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi Needs Dev Ready for, and needs developer efforts [Type] Enhancement A suggestion for improvement.
Projects
No open projects
WordPress 6.4 Editor Tasks
Status: Punted to 6.5
Milestone
No milestone
Development

No branches or pull requests
5 participants
@richtabor @jordesign @carolinan @annezazu @akasunil