Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent use of the chevron icon in the dark sidebar #48591

Closed
jameskoster opened this issue Feb 28, 2023 · 6 comments · Fixed by #50076
Closed

Inconsistent use of the chevron icon in the dark sidebar #48591

jameskoster opened this issue Feb 28, 2023 · 6 comments · Fixed by #50076
Assignees
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing")

Comments

@jameskoster
Copy link
Contributor

jameskoster commented Feb 28, 2023

The dark sidebar in the site editor utilises a drill down pattern to expose subsequent levels of navigation.

At the root level of Design, we indicate this behaviour by appending a chevron to each menu item:

Screenshot 2023-02-28 at 13 23 19

However, in each of the other panels, this chevron does not appear, despite the menu items having the same behaviour:

Screenshot 2023-02-28 at 13 24 06

We should be consistent so that users are better able to predict how the UI will behave. That means either removing the chevrons at the root, or adding them to the other panels.

Important note: We already use the small chevron icon in the Navigation panel to indicate the presence of a submenu:

Screenshot 2023-02-28 at 13 32 04

This is an established pattern in List View as well. If we elect to use chevrons as a universal drilldown indicator for menu items in the dark sidebar, then we need to make sure there's no confusion between the two.

@jameskoster jameskoster added Needs Design Needs design efforts. [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") labels Feb 28, 2023
@ndiego ndiego moved this to ❓ Triage in WordPress 6.2 Editor Tasks Mar 5, 2023
@ndiego ndiego moved this from ❓ Triage to 🐛 Punted to 6.2.1 in WordPress 6.2 Editor Tasks Mar 8, 2023
@jasmussen jasmussen moved this to Todo in 6.3 Design Mar 16, 2023
@annezazu annezazu moved this to 🎨 Needs design in Gutenberg Phase 2: Customization Mar 16, 2023
@jameskoster
Copy link
Contributor Author

I think it would be good to try applying the small chevron to any item that invokes a drilldown.

@jameskoster jameskoster added Needs Dev Ready for, and needs developer efforts and removed Needs Design Needs design efforts. labels Mar 22, 2023
@jameskoster jameskoster moved this from Needs design to Needs dev in 6.3 Design Mar 22, 2023
@annezazu annezazu moved this to ❓ Triage in WordPress 6.2.x Editor Tasks Apr 10, 2023
@Mamaduka Mamaduka moved this from 🐛 Punted to 6.2.1 to 🦵 Punted to 6.3 in WordPress 6.2 Editor Tasks Apr 13, 2023
@priethor priethor moved this from 🎨 Needs design to 💻 Needs development in Gutenberg Phase 2: Customization Apr 19, 2023
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Apr 25, 2023
@apeatling
Copy link
Contributor

apeatling commented Apr 25, 2023

I've opened a PR to fix this. It does not address the navigation screen since we already use chevrons there. I'm happy to address the nav screen in a different PR, or change the chevron to something else and include the nav screen in the open PR. Update: The nav menus work differently so don't need this.

@github-project-automation github-project-automation bot moved this from 💻 Needs development to ✅ Done in Gutenberg Phase 2: Customization Apr 27, 2023
@github-project-automation github-project-automation bot moved this from 🦵 Punted to 6.3 to ✅ Done in WordPress 6.2 Editor Tasks Apr 27, 2023
@jameskoster
Copy link
Contributor Author

If you don't mind I'm going to re-open, purely because we won't have consistency until the nav menu items are updated.

@jameskoster jameskoster reopened this Apr 28, 2023
@apeatling
Copy link
Contributor

Thanks, yes makes sense. That was automated when the PR closed. 👍

@apeatling
Copy link
Contributor

Follow up PR for navigation screen #50149

@apeatling apeatling removed the Needs Dev Ready for, and needs developer efforts label May 1, 2023
@jameskoster
Copy link
Contributor Author

I think we're in a good spot with this one now.

@jameskoster jameskoster moved this from Needs dev to Done in 6.3 Design Jul 12, 2023
@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing")
Projects
Status: Done
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants