Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style Book: Inconsistent preview of Custom HTML widget between styles variations #48152

Open
franzaurus opened this issue Feb 17, 2023 · 3 comments
Labels
[Feature] Theme Style Variations Related to style variations provided by block themes Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Bug An existing feature does not function as intended

Comments

@franzaurus
Copy link
Contributor

Description

When browsing through the style variations of a block theme, the Custom HTML widget preview on the Style Book is displayed inconsistently. This is because the background of the currently active style variation is carried over to other style variations.

This issue affected WP 6.2 Beta 2 and Gutenberg 15.1.1 as well.

I've checked #9129 but it is not related.

Step-by-step reproduction instructions

  1. Activate a block theme (TT3 or other)
  2. Select a style variation
  3. Go to its Style Book
  4. Scroll through the Custom HTML widget
  5. While staying in the Style Book, browse through a few more style variations
  6. Observe the Custom HTML’s background preview doesn’t follow the changing styles

Screenshots, screen recording, code snippet

On WP 6.2 Beta 2
custom-html-inconsistent-display-stylebook

On Gutenberg 15.1.1
custom-html-inconsistent-display-stylebook-gutenberg

Environment info

  • WP Core 6.2 Beta 2
  • Gutenberg 15.1.1
  • Firefox 111.0b1
  • Chrome 109.0.5414.120
  • TT3 & Beaumont themes.

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@franzaurus
Copy link
Contributor Author

It might be related to #46758

@mrfoxtalbot mrfoxtalbot added [Type] Bug An existing feature does not function as intended Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Feature] Theme Style Variations Related to style variations provided by block themes labels Feb 20, 2023
@Mamaduka
Copy link
Member

Mamaduka commented Mar 7, 2023

Hi, @franzaurus

Are you still able to reproduce the issue with WP 6.2 beta 4?

@franzaurus
Copy link
Contributor Author

Hello, @Mamaduka. The issue can still be reproduced in WP 6.2 beta 5.

style-book-widget-custom-html-variant-beta5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Theme Style Variations Related to style variations provided by block themes Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

3 participants