Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A Way to Disable Export Theme #46661

Open
unsalkorkmaz opened this issue Dec 19, 2022 · 6 comments · May be fixed by #69107
Open

A Way to Disable Export Theme #46661

unsalkorkmaz opened this issue Dec 19, 2022 · 6 comments · May be fixed by #69107
Assignees
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended [Type] WP Core Ticket Requires an upstream change from WordPress. Core Trac ticket should be linked.

Comments

@unsalkorkmaz
Copy link

What problem does this address?

This button tries to zip my whole theme which as node_modules with 500MB content:
Screenshot 2022-12-19 at 20 03 38

What is your proposed solution?

I need a way to disable this.

@t-hamano
Copy link
Contributor

@unsalkorkmaz
Thanks for your reporting.

My understanding is that the node_modules directory is explicitly excluded and I could not reproduce this in my environment.

We would be happy to receive more information on WordPress version, Gutenberg plugin version, OS, etc.

@t-hamano t-hamano added the [Status] Needs More Info Follow-up required in order to be actionable. label Dec 21, 2022
@unsalkorkmaz
Copy link
Author

unsalkorkmaz commented Dec 21, 2022

My node_modules is in directory.

wp-content/themes/theme_name/headless/node_modules

I will post a video today

@unsalkorkmaz
Copy link
Author

unsalkorkmaz commented Dec 21, 2022

Here is the video:
https://www.youtube.com/watch?v=9F1LtmMrjsY
(new uploaded, proccessing atm)

You can see CPU spike in right macos m1 menu..

@unsalkorkmaz
Copy link
Author

And lets say I want to give demo for my premium theme.. Why the hell would I want a download button?

@t-hamano
Copy link
Contributor

@unsalkorkmaz

Thank you for the detailed explanation.
Indeed, it seems that the node_modules directory in the sub directory will be included.
I was also able to reproduce the following commands:

  • cd ../path/to/wp-content/themes/twentytwentythree/assets
  • npm install some-package
  • Export the theme.

The increase in CPU load and the time it takes to run Export is probably due to the large number of files being scanned.

I think it might be a good idea to submit a core ticket since the theme export feature is already in the WordPress core and I believe it is a PHP side issue.

@t-hamano t-hamano added [Type] Bug An existing feature does not function as intended [Type] WP Core Ticket Requires an upstream change from WordPress. Core Trac ticket should be linked. and removed [Type] Enhancement A suggestion for improvement. [Status] Needs More Info Follow-up required in order to be actionable. labels Dec 23, 2022
@unsalkorkmaz
Copy link
Author

Ok. I opened a ticket;
https://core.trac.wordpress.org/ticket/57379#ticket

@annezazu annezazu added [Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") and removed [Feature] Full Site Editing labels Jul 24, 2023
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Site Editor Related to the overarching Site Editor (formerly "full site editing") [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended [Type] WP Core Ticket Requires an upstream change from WordPress. Core Trac ticket should be linked.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants