Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A themeable and scalable primitive system #42388

Open
SaxonF opened this issue Jul 13, 2022 · 5 comments
Open

A themeable and scalable primitive system #42388

SaxonF opened this issue Jul 13, 2022 · 5 comments
Labels
[Feature] UI Components Impacts or related to the UI component system General Interface Parts of the UI which don't fall neatly under other labels. Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.

Comments

@SaxonF
Copy link
Contributor

SaxonF commented Jul 13, 2022

What problem does this address?

As the editor expands in what it is capable of, so too will the complexity and density of its controls. The current UI language is quite heavy which can be distracting when faced with a dense panel of settings. There is also the ever present discussion of dark mode which is on its way to becoming expected in today's software.

What is your proposed solution

Its worthwhile discussing whether there are some iterations we can make to our wp/components primitive system so that they are more suitable for dense interfaces, as well as working our towards supporting themes.

The concepts below make use of the Radix Color System which includes hand picked light and dark themes. Others have approached light and dark mode in a more programmatic way which is also worth exploring.

Early concepts which soften stroke colour, adjust spacing and typography (using Inter).

image

Uppercase inspector section headings like we use in global styles

image

Some earlier explorations around dark mode
image

A more expressive example
image

@annezazu annezazu added General Interface Parts of the UI which don't fall neatly under other labels. Needs Design Feedback Needs general design feedback. [Feature] UI Components Impacts or related to the UI component system labels Jul 13, 2022
@pablohoneyhoney
Copy link

I'm not entirely sure how the above progresses what's currently up, to be honest. There are a lot of mixed details in the UI, and challenges with a11y. The breadcrumb isn't an ideal application in such a constraint space, and the compressed elements is overwhelmingly tight and make many UIs clash.

Aligning the uppercases could be a specific task to look at.

And the dark mode could be interesting too, if the community is open to it. But it has other set of challenges, like how it affects moving pieces like admin darker elements, nav sidebar, or exploded view, as you note above (it'd be better to explore it with what's in production, it's confusing to see it with foreign elements).

@SaxonF
Copy link
Contributor Author

SaxonF commented Jul 15, 2022

@pablohoneyhoney This is just the start of the conversation so of course we can iterate and explore other options. Maybe a better starting point is looking at how our editor compares against other site builders and design tools, some of which are WordPress builders.

image

My concern right now is that the current interface starts to break a little when we get into more granular editing capabilities such layout, typography details etc. Spacing and the weight of elements such as inputs/controls (strong stroke) are two examples that imo draw a lot of attention away from the canvas and make it hard to focus. I think there are some relatively small refinements we can make to improve that. Colours are driven by Radix so should all be accessible, both in light and dark.

Of course, this all subjective as design is :)

@SaxonF
Copy link
Contributor Author

SaxonF commented Jul 18, 2022

like how it affects moving pieces like admin darker elements, nav sidebar, or exploded view, as you note above (it'd be better to explore it with what's in production, it's confusing to see it with foreign elements).

On this point, I'm not a fan of the darker canvas elements we've introduced like the exploded view partly because they require us to use both light and dark variations of our components within the same environment. I think we can learn from how Figma handles dark mode and how it affects the default colour of the canvas.

@SaxonF
Copy link
Contributor Author

SaxonF commented Feb 27, 2023

Another little iteration.

  • Capitalised headings used for sections rather than every input
  • Less borders to soften interface (inputs, secondary button, menu items)
  • More use of muted/secondary text colour
  • 36px input height vs 40px
  • [0,3,5] border radius scale
condense.mp4

@jasmussen
Copy link
Contributor

Thanks for the energy. There are a few things to like here, notably the thought put into dark mode, and some of the thought put into label/allcaps systematization.

I think the layout panel revamp is worth extracting as a separate focused exploration.

I will admit that I'm not convinced about the larger changes put into the basic metrics. It's not actually clear to me that this different visual solves problems with the existing target outlined at #46734, so before we change course midstream, it seems worth really understanding what problems these solve. Some of the decisions, specifically, contradict previous decisions to focus on 32 and 40 px controls.

@jordesign jordesign added the [Type] Enhancement A suggestion for improvement. label Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] UI Components Impacts or related to the UI component system General Interface Parts of the UI which don't fall neatly under other labels. Needs Design Feedback Needs general design feedback. [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

5 participants