Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Customise Nav block mobile menu toggle text #40580

Open
getdave opened this issue Apr 25, 2022 · 3 comments
Open

Customise Nav block mobile menu toggle text #40580

getdave opened this issue Apr 25, 2022 · 3 comments
Assignees
@javierarce
Labels
[Block] Navigation Affects the Navigation Block Needs Dev Ready for, and needs developer efforts [Type] Enhancement A suggestion for improvement.

Comments

@getdave
Copy link
Contributor

getdave commented Apr 25, 2022

What problem does this address?

Under the display option in the site editor, you can choose to replace the hamburger icon by the word Menu. However you cannot customise this text.

What is your proposed solution?

It might be useful to allow users to customise the text used here if they so wish.
@getdave getdave added the [Block] Navigation Affects the Navigation Block label Apr 25, 2022
@carolinan carolinan added [Type] Enhancement A suggestion for improvement. Needs Design Needs design efforts. labels Apr 26, 2022
@carolinan
Copy link
Contributor

carolinan commented Apr 28, 2022 •
edited
Loading

Should this be a text field in the display panel?

@javierarce javierarce self-assigned this Sep 8, 2022
@javierarce javierarce mentioned this issue Sep 9, 2022
Open
@javierarce
Copy link
Contributor

javierarce commented Sep 9, 2022 •
edited
Loading

As part of this enhancement I've started working on this one too. Here are a couple of proposals (still WIP):

This initial one would allow users to switch between icons and text and would be easy to implement after the previous issue is addressed:

image

This one would give more options to customize, since users could switch the options independently. It would require using an image dropdown

image

@javierarce
Copy link
Contributor

javierarce commented Sep 13, 2022 •
edited
Loading

I added a new and more simple iteration here

image

@javierarce javierarce added Needs Dev Ready for, and needs developer efforts and removed Needs Design Needs design efforts. labels Sep 13, 2022
@annezazu annezazu mentioned this issue Sep 23, 2022
Open
@stephymiehle stephymiehle mentioned this issue Sep 23, 2022
Open
@jameskoster jameskoster mentioned this issue Mar 22, 2023
Open
@mikachan mikachan mentioned this issue May 31, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@javierarce javierarce

Labels
[Block] Navigation Affects the Navigation Block Needs Dev Ready for, and needs developer efforts [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@javierarce @getdave @carolinan