Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pressing Enter on a Block should engage "isTyping" mode #3846

Closed
mtias opened this issue Dec 7, 2017 · 3 comments
Closed

Pressing Enter on a Block should engage "isTyping" mode #3846

mtias opened this issue Dec 7, 2017 · 3 comments
Assignees
@noisysocks
Labels
[Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... [Type] Enhancement A suggestion for improvement. [Type] Task Issues or PRs that have been broken down into an individual action to take

Comments

@mtias
Copy link
Member

mtias commented Dec 7, 2017

When you press enter on a block (say, heading) we should engage isTyping mode. At the moment it keeps the mode you are in. So if you have moved your mouse and pressed enter, the new block shows the toolbar.
@mtias mtias added [Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... [Type] Enhancement A suggestion for improvement. [Type] Task Issues or PRs that have been broken down into an individual action to take labels Dec 7, 2017
@ellatrix
Copy link
Member

Correct, we only trigger isTyping on inside a block, not backspace/enter etc. cross blocks. If isTyping was already true before though, it will keep the toolbar hidden. If it was visible, it won't hide it. So I guess you're saying it should di the toolbars on any keyboard input actions?

@ellatrix
Copy link
Member

This again seems like one of those cases where it would be better if Editable could directly adjust the state instead of through the block.

@mtias
Copy link
Member Author

mtias commented Dec 26, 2017

Yes, I mean we should treat enter as a cross-block isTyping action.

@noisysocks noisysocks self-assigned this Jan 11, 2018
@noisysocks noisysocks mentioned this issue Jan 11, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@noisysocks noisysocks

Labels
[Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... [Type] Enhancement A suggestion for improvement. [Type] Task Issues or PRs that have been broken down into an individual action to take
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mtias @noisysocks @ellatrix