Video block settings: Poster image label needs spacing

[sabernhardt]

Description

In the Video block settings, the Poster image label has no bottom margin or padding. The margin was intentionally increased from 4px to 8px in #20754, but that has been missing since WordPress 5.6.

Should the label use StyledLabel instead of BaseControl.VisualLabel?

gutenberg/packages/block-library/src/video/edit.js

Lines 201 to 203 in e192d50

	<BaseControl.VisualLabel>
	{ __( 'Poster image' ) }
	</BaseControl.VisualLabel>

(originally reported on Trac)

Step-by-step reproduction instructions

1. Open the post editor.
2. Add a Video block, and upload or select a video.
3. Make sure the settings sidebar is open and scroll to view the Poster image control with no spacing between the label and the button.
4. Select a poster image to see the focus outline obscure part of the label text.

Screenshots, screen recording, code snippet

Before selecting a poster image:

With the poster image:

(screenshots taken in my 5.9 trunk installation, without the plugin)

Environment info

• WP 5.8.1, with and without Gutenberg 11.7.0
• Firefox 93
• Windows 10 20H2 Home

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes