Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quote block's deletion doesn't persist #35624

Closed
hypest opened this issue Oct 14, 2021 · 1 comment · Fixed by #35721
Closed

Quote block's deletion doesn't persist #35624

hypest opened this issue Oct 14, 2021 · 1 comment · Fixed by #35721
Assignees
Labels
[Block] Quote Affects the Quote Block [Priority] High Used to indicate top priority items that need quick attention [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended

Comments

@hypest
Copy link
Contributor

hypest commented Oct 14, 2021

Description

Trying to delete a Quote block by backspacing, removes the block from the editor but the block is still there in "Code editor" mode. I'd expect the block to not be there after backspacing it.

Originally spotted on the mobile app but we then noticed that it happens on the web clients too.

Step-by-step reproduction instructions

  1. Run Gutenberg off a merged PR like this one: http://m62bf9dp.gutenberg.run/wp-admin/post-new.php
  2. Add a quote block. (it's fine to leave it empty)
  3. Add a paragraph block after the Quote block and type in a couple of characters
  4. Focus the Quote block input
  5. Hit backspace to delete the Quote block
  6. Switch to "Code editor" mode from the 3-dot menu on the top-right
  7. Notice the Quote block's markup still being there 💥

Screenshots, screen recording, code snippet

quote_wont_delete_web.mov

Environment info

  • Gutenberg off trunk b6f0bdf
  • Browser: Firefox 93.0

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@hypest hypest added the [Type] Bug An existing feature does not function as intended label Oct 14, 2021
@youknowriad youknowriad added [Block] Quote Affects the Quote Block [Priority] High Used to indicate top priority items that need quick attention labels Oct 14, 2021
@fluiddot
Copy link
Contributor

fluiddot commented Oct 14, 2021

I think this might be related to the changes introduced in #34241, I tried to reproduce this issue using the previous commit (d8808e8) of the PR merge commit (39806aa) in trunk, and the issue didn't happen.

cc @youknowriad

@hypest hypest changed the title Quote blocks deletion doesn't persist Quote block's deletion doesn't persist Oct 14, 2021
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Quote Affects the Quote Block [Priority] High Used to indicate top priority items that need quick attention [Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants