Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected "Block Settings" sections added to Customizer #35041

Closed
chad1008 opened this issue Sep 22, 2021 · 3 comments
Closed

Unexpected "Block Settings" sections added to Customizer #35041

chad1008 opened this issue Sep 22, 2021 · 3 comments
Labels
[Feature] Widgets Customizer Ability to add and edit blocks in Customize → Widgets. [Type] Regression Related to a regression in the latest release

Comments

@chad1008
Copy link
Contributor

Description

Starting with the v11.5.0 release, the Customizer is displaying a "Block Widgets" section for each of the active theme's registered widget areas. Opening one of these sections at first reveals a blank panel. Clicking the Customizer's "back" button then reveals the corresponding widget area, rather than actually backing out to initial Customizer view. From there, the user can edit blocks normally and the "back" button will lead to the initial Customizer view.

This appears to have been introduced in #34543.

Step-by-step reproduction instructions

  1. Activate a theme with registered widget areas (I tested with Twenty Twenty)
  2. Open Appearance > Customize
  3. Note the Block Settings sections. On Twenty Twenty these appear just above the normal "Widgets" section
  4. Open one of the Block Settings. You'll get either a blank panel (first open) or "No Block Selected" (subsequent opens)
  5. Back out one step in Customizer
  6. Now the blocks for the related widget area appear and can be edited normall
  7. Back out one more step
  8. You should now be back to start

The Widgets panel and indivudal block settings all appear to function normally when accessed through the usual flow.

Screenshots, screen recording, code snippet

Screen Shot 2021-09-22 at 08 19 12

Environment info

WP 5.8.0, GB 11.5.0 and 11.5.1, running Twenty Twenty
Chrome 93.0.4577.63
MacOS 11.5.2

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@noisysocks noisysocks added [Feature] Widgets Customizer Ability to add and edit blocks in Customize → Widgets. [Type] Regression Related to a regression in the latest release labels Sep 23, 2021
@AlexanderMonsanto
Copy link

zd-4320575

@mreishus
Copy link
Contributor

@chad1008 This should be solved by #35055 which is now merged.

@noisysocks
Copy link
Member

I believe this was fixed. I can no longer reproduce it running latest WP/Gutenberg.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Widgets Customizer Ability to add and edit blocks in Customize → Widgets. [Type] Regression Related to a regression in the latest release
Projects
None yet
Development

No branches or pull requests

4 participants