Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape key in customize widgets editor exits back to main customizer menu #31972

Closed
talldan opened this issue May 19, 2021 · 2 comments
Closed
Labels
[Feature] Widgets Customizer Ability to add and edit blocks in Customize → Widgets. [Type] Bug An existing feature does not function as intended

Comments

@talldan
Copy link
Contributor

talldan commented May 19, 2021

Description

As the title says, escape key in customize widgets editor exits back to main customizer menu, which overrides some other uses for escape:

  • Navigation/Select mode
  • Using escape to close dropdowns (block settings, editor more menu)

Step-by-step reproduction instructions

  1. Open the customize widgets editor
  2. Select a block

Expected behaviour

Navigation mode is entered

Actual behaviour

The editor is closed and the page navigates back to the main customizer menu

@talldan talldan added [Type] Bug An existing feature does not function as intended [Feature] Widgets Customizer Ability to add and edit blocks in Customize → Widgets. labels May 19, 2021
@critterverse
Copy link
Contributor

We also have #31730 but can close that in favor of removing the "back" functionality altogether, let me know!

(We should take a look at the back functionality for Enter as well — this currently takes you back a step when you first open the Customizer editor before selecting anything, otherwise seems to be disabled)

@talldan
Copy link
Contributor Author

talldan commented May 20, 2021

Cool, I missed that one. I'll close this in favour of #31730 and mention about popovers there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Widgets Customizer Ability to add and edit blocks in Customize → Widgets. [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

2 participants