Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inserter menu: Assure a minimum blocks list height #30286

Closed
fluiddot opened this issue Mar 26, 2021 · 1 comment · Fixed by #30291
Closed

Inserter menu: Assure a minimum blocks list height #30286

fluiddot opened this issue Mar 26, 2021 · 1 comment · Fixed by #30291
Assignees
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Type] Bug An existing feature does not function as intended

Comments

@fluiddot
Copy link
Contributor

Description

Related to adding the reusable blocks list to the inserter menu, I added segmented control for having tab navigation and I realised that the blocks list size is reduced by the rest of elements.

Step-by-step reproduction instructions

  1. Add an empty View with a specific height (something like: <View style={ { backgroundColor: 'red', height: 120 } } />) to the inserter menu.
  2. Open the inserter menu
  3. Observe that the blocks list is too small

Expected behaviour

The blocks list should have a minimum height.

Actual behaviour

The blocks list can be too small if the rest of content pushes it.

Screenshots or screen recording (optional)

WordPress information

  • WordPress version: N/A
  • Gutenberg version: N/A
  • Are all plugins except Gutenberg deactivated? N/A
  • Are you using a default theme (e.g. Twenty Twenty-One)? N/A

Device information

  • Device: iPhone 8 (simulator)
  • Operating system: iOS 14.2
  • WordPress app version: 17.0
@fluiddot fluiddot added the Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) label Mar 26, 2021
@fluiddot fluiddot self-assigned this Mar 26, 2021
@fluiddot
Copy link
Contributor Author

One option I'm evaluating is to add a header prop to the BottomSheet component, this way we could render the extra elements (like the search input) as the header and let the content (the blocks list) to grow and fit all the height.

cc @jhnstn

@fluiddot fluiddot linked a pull request Mar 26, 2021 that will close this issue
7 tasks
@fluiddot fluiddot added the [Type] Bug An existing feature does not function as intended label Mar 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant