Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new category form: more a11y improvements #2634

Closed
afercia opened this issue Sep 1, 2017 · 2 comments
Closed

Add new category form: more a11y improvements #2634

afercia opened this issue Sep 1, 2017 · 2 comments
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Enhancement A suggestion for improvement.

Comments

@afercia
Copy link
Contributor

afercia commented Sep 1, 2017

Splitting this out from #2588, see #2572.

A couple improvements worth considering for the "Add new category" mini-form in the sidebar:

1
When adding a new category, the submit button gets disabled to avoid multiple submissions. Elements that have focus should never gets disabled. When using a keyboard and activating the button, it gets disabled (see disabled={ adding }) thus causing a focus loss. Ideally, the button should just noop. This applies to all other similar cases.

2
Add a Speak message when a term is successfully added (maybe also on failure?)

@afercia afercia added the [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). label Sep 1, 2017
@karmatosed karmatosed added the [Type] Enhancement A suggestion for improvement. label Sep 4, 2017
@karmatosed
Copy link
Member

If I am correct, none of these have design implications? I would +1 anything being just implemented if it doesn't need mocking up/change experience for all and would improve the experience for all.

@afercia
Copy link
Contributor Author

afercia commented Sep 4, 2017

Correct! The only (barely noticeable) difference would be the button not getting the "disabled" style.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

2 participants