Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lower/Uppercase Strings #23094

Closed
Soean opened this issue Jun 11, 2020 · 4 comments
Closed

Lower/Uppercase Strings #23094

Soean opened this issue Jun 11, 2020 · 4 comments
Labels
Internationalization (i18n) Issues or PRs related to internationalization efforts Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) Needs Technical Feedback Needs testing from a developer perspective.

Comments

@Soean
Copy link
Member

Soean commented Jun 11, 2020

Describe the bug
I started the translation of Gutenberg 8.3 for german and saw the new string 'Color Settings'. Because I was sure that we already translated this string, I looked where it came from:

const title = isWebPlatform
		? __( 'Color settings' )
		: __( 'Color Settings' );

https://github.com/WordPress/gutenberg/blob/master/packages/block-library/src/button/color-edit.js#L61-L63

Why are we doing this? So we always have 2 different translations for the strings. If we really need this, is there an anternative like using CSS?

@Soean Soean added the Internationalization (i18n) Issues or PRs related to internationalization efforts label Jun 11, 2020
@gziolo gziolo added Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) Needs Technical Feedback Needs testing from a developer perspective. labels Jun 14, 2020
@gziolo
Copy link
Member

gziolo commented Jun 14, 2020

@pinarol or @hypest, any ideas why we use two different strings here?

@pinarol
Copy link
Contributor

pinarol commented Jun 15, 2020

@iamthomasbishop Is this an intended thing on mobile side to use capitalized first letter per word for section titles? I think we should keep platforms same and use what web is using, which is Color settings. Wdyt?

@mtias
Copy link
Member

mtias commented May 28, 2021

I'm seeing this doesn't seem relevant anymore in the source code.

@mtias mtias closed this as completed May 28, 2021
@hypest
Copy link
Contributor

hypest commented Jun 1, 2021

For context, we're moving to Sentence case on mobile too so yeah, thanks for closing this one as not relevant anymore @mtias 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internationalization (i18n) Issues or PRs related to internationalization efforts Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) Needs Technical Feedback Needs testing from a developer perspective.
Projects
None yet
Development

No branches or pull requests

5 participants