Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calendar alignment issues #22387

Open
jancavan opened this issue May 15, 2020 · 8 comments
Open

Calendar alignment issues #22387

jancavan opened this issue May 15, 2020 · 8 comments
Labels
CSS Styling Related to editor and front end styles, CSS-specific issues. General Interface Parts of the UI which don't fall neatly under other labels. [Type] Bug An existing feature does not function as intended

Comments

@jancavan
Copy link

jancavan commented May 15, 2020

I'm working on adding timezone when scheduling posts/pages and noticed a few things we can improve to make our calendar look better. Looking at the current calendar:

Screen Shot 2020-05-15 at 10 47 51 AM

  • Days are misaligned with the corresponding days of the week
  • Month/year is off-center
  • Entire calendar is off-center within the card
  • Days that fall outside of the current month are missing (which I think is pretty non-standard for calendars. This means I have to go over another month if I happen to be looking for a day that falls outside the month I'm on)
  • Help link is misaligned
  • The hour and date fields can contain more than 2 digits
  • The year field can contain more than 4 digits (it's trying to be scalable, but might be a bit much?)

Here's a mockup addressing the items mentioned above.

I also:

  • Expanded the month dropdown to get rid of the extra white space on its right
  • Updated the left/right arrows:
    -- to use the ones we are using in the Welcome modal
    -- use darker colors. The arrows are really faint right now, they almost look like they're disabled
  • Another idea, although I missed including it in the mockups, is to condense AM/PM into a dropdown

Screen Shot 2020-05-15 at 10 49 59 AM

Out of curiosity, do we need "Calendar Help"? Maybe "Navigating with a keyboard" might be helpful, but "Click to Select" is not necessary it seems?
Screen Shot 2020-05-15 at 11 04 39 AM

@spencerfinnell
Copy link

When using DatePicker (no time) there is an extra border at the top as well:

Screen Shot 2020-05-15 at 2 53 36 PM

@talldan talldan added [Type] Bug An existing feature does not function as intended General Interface Parts of the UI which don't fall neatly under other labels. CSS Styling Related to editor and front end styles, CSS-specific issues. labels May 22, 2020
@mapk
Copy link
Contributor

mapk commented May 28, 2020

@jancavan, really good! Looking at the current and your proposed design solution is night and day.

I've got a bit of feedback:

1. Change or Edit?

Do we use the word, "Change" for editing in other areas? I noticed in the wp-admin we tend to use the word "Edit." Are you opposed to that option?

2. AM PM

I'm not entirely sure if we need AM/PM as toggles or a dropdown. We can check with Accessibility Team on that.

3. Calendar help

This, I believe, is carried over from the Classic editor. Removing the "click to select" feels okay, but I'd leave the keyboards instructions.

4. Additional link missing

Keep in mind that there is also a recent change that brought a "reset" link into the DatePicker now.

Screen Shot 2020-05-27 at 5 25 28 PM

@jancavan
Copy link
Author

Do we use the word, "Change" for editing in other areas? I noticed in the wp-admin we tend to use the word "Edit." Are you opposed to that option?

I only saw one in account settings, although I am fine using "edit".

Screen Shot 2020-05-28 at 1 38 54 PM

@mapk
Copy link
Contributor

mapk commented May 28, 2020

Yea, let's go with "Edit." I know "Edit" appears all over the wp-admin.

Oh BTW, the "reset" link is only visible if you've scheduled a post. Also, how does the "Edit" option you're presenting work with post scheduling? Have you thought through that flow?

@jancavan
Copy link
Author

Yes, my thought is for it to just go to /settings/general. But I'd really like for uniformity in the timezones in the calendar and in settings. And for the timezones to be more helpful - ie: with offset and example city instead of just city names and ambiguous offsets.

@carolinan
Copy link
Contributor

I believe the alignment issues have been solved. Is adding a reset link still relevant?
Current design:
Date picker, with dates aligning under week days.

@skorasaurus
Copy link
Member

skorasaurus commented Apr 22, 2024

think all of these issues are now resolved except for "Days that fall outside of the current month are missing (which I think is pretty non-standard for calendars. This means I have to go over another month if I happen to be looking for a day that falls outside the month I'm on)"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CSS Styling Related to editor and front end styles, CSS-specific issues. General Interface Parts of the UI which don't fall neatly under other labels. [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants
@spencerfinnell @mapk @talldan @skorasaurus @jancavan @carolinan and others