Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gutenberg 7.6 does not load on MS Edge 44 #20652

Closed
mmtr opened this issue Mar 5, 2020 · 10 comments · Fixed by #20690
Closed

Gutenberg 7.6 does not load on MS Edge 44 #20652

mmtr opened this issue Mar 5, 2020 · 10 comments · Fixed by #20690
Assignees
Labels
Browser Issues Issues or PRs that are related to browser specific problems [Status] In Progress Tracking issues with work in progress

Comments

@mmtr
Copy link
Contributor

mmtr commented Mar 5, 2020

Describe the bug
Accessing the block editor when using Gutenberg 7.6 on MS Edge 18 results in a blocking error that prevents users from editing or creating post and pages.

Screen Shot 2020-03-05 at 12 12 47

The issue seems to be specific to Gutenberg 7.6 and MS Edge 18, since it is not present when using either MS Edge 80 or Gutenberg 7.5

To reproduce

  1. On MS Edge 18, go to wordpress.org/gutenberg
  2. See error.

Alternative steps:

  1. Install and activate Gutenberg 7.6.
  2. On MS Edge 18, start a new post.
  3. See error.

Expected behavior
The editor should load successfully.

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser: MS Edge
  • Version: 18
@mmtr mmtr added the Browser Issues Issues or PRs that are related to browser specific problems label Mar 5, 2020
@Soean
Copy link
Member

Soean commented Mar 5, 2020

MS Edge 18 is very old and we don't support this browser anymore, or do you mean 81?

@gwwar
Copy link
Contributor

gwwar commented Mar 5, 2020

From what I've read in https://make.wordpress.org/core/handbook/best-practices/browser-support/ Edge 18 still has more than 1% usage. So theoretically we should be supporting this one.

@aduth
Copy link
Member

aduth commented Mar 5, 2020

I can reproduce an issue on WordPress.org/gutenberg , but not when running the plugin directly.

Or at least, I assume that this is running Edge 18.x :

image

@aduth
Copy link
Member

aduth commented Mar 5, 2020

I'm not sure why I wasn't able to reproduce earlier, but I can do so now.

Debugging was quite difficult, but after some process of elimination, I think it is caused by this rule:

// Rules inside this query are only run by Microsoft Edge.
// Edge miscalculates `calc`, so we have to add some buffer.
// See also https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/15637241/
@supports (-ms-ime-align:auto) {
width: calc((100% - #{ $grid-unit-20 } * #{ $i - 1 }) / #{ $i } - 1px);
}

Commenting this line is enough to make the difference in whether the editor loads or not in Edge 18.x.

What's confusing to me, however, is that this style has existed for quite some time, originally introduced in #13326, then most recently updated in #19344. These recent updates haven't yet been published in any plugin release, so I wouldn't expect that to be the source of any regression.

@jasmussen As author of #13326, I'm not sure if this might ring any bells with you? Could we imagine some alternative solution to the original issue which doesn't require this specific formulation of @supports in the stylesheet?

It's still confusing me to me that this would only recently have become an issue. 🤔

@aduth
Copy link
Member

aduth commented Mar 5, 2020

In some further testing, it does not appear to crash when using WordPress trunk (5.5-alpha-47431), which I would expect to be the equivalent of WordPress 5.4-RC1, and thus not affecting the upcoming WordPress 5.4 release. It would be good if someone else could confirm this.

@gwwar
Copy link
Contributor

gwwar commented Mar 5, 2020

@aduth is there a download link for the 5.4 RC1? I was having trouble finding it.

Edit: ah it was under https://wordpress.org/wordpress-5.4-RC1.zip

@gwwar
Copy link
Contributor

gwwar commented Mar 6, 2020

@aduth I think 5.4-RC1 should be okay with Edge 18

Screen Shot 2020-03-05 at 4 24 23 PM

Screen Shot 2020-03-05 at 4 27 22 PM

@talldan talldan changed the title Gutenberg 7.6 does not load on MS Edge 18 Gutenberg 7.6 does not load on MS Edge 44 Mar 6, 2020
@talldan
Copy link
Contributor

talldan commented Mar 6, 2020

It looks like the browser version is v44 (but EdgeHTML v18) in those screenshots, so I've changed the title to match.

@jasmussen
Copy link
Contributor

@jasmussen As author of #13326, I'm not sure if this might ring any bells with you? Could we imagine some alternative solution to the original issue which doesn't require this specific formulation of @supports in the stylesheet?

😩

Oh, the IE tax.

Given that Microsoft has released a Chromium based edge, and is not only actively rolling pushing it out to Windows machines running classic Edge, but replacing the classic Edge too (updating the shortcuts to point the the new edge and disabling the classic Edge), I would say that the immediate next step is to remove any Edge related CSS code, especially if it's causing these issues.

The original gallery margin issue that it fixed is not only Classic-Edge specific, but it's not fundamentally a breaking issue, and given classic Edge is actively being deprecated, it seems time to relieve ourself of that hack.

@aduth
Copy link
Member

aduth commented Mar 6, 2020

The changes proposed at #20690 appear to resolve the crash, removing the Edge-specific styles while still retaining the original fix intended with #13326.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Browser Issues Issues or PRs that are related to browser specific problems [Status] In Progress Tracking issues with work in progress
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants