-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gutenberg 7.6 does not load on MS Edge 44 #20652
Comments
MS Edge 18 is very old and we don't support this browser anymore, or do you mean 81? |
From what I've read in https://make.wordpress.org/core/handbook/best-practices/browser-support/ Edge 18 still has more than 1% usage. So theoretically we should be supporting this one. |
I'm not sure why I wasn't able to reproduce earlier, but I can do so now. Debugging was quite difficult, but after some process of elimination, I think it is caused by this rule: gutenberg/packages/block-library/src/gallery/style.scss Lines 108 to 113 in 8a94254
Commenting this line is enough to make the difference in whether the editor loads or not in Edge 18.x. What's confusing to me, however, is that this style has existed for quite some time, originally introduced in #13326, then most recently updated in #19344. These recent updates haven't yet been published in any plugin release, so I wouldn't expect that to be the source of any regression. @jasmussen As author of #13326, I'm not sure if this might ring any bells with you? Could we imagine some alternative solution to the original issue which doesn't require this specific formulation of It's still confusing me to me that this would only recently have become an issue. 🤔 |
In some further testing, it does not appear to crash when using WordPress trunk (5.5-alpha-47431), which I would expect to be the equivalent of WordPress 5.4-RC1, and thus not affecting the upcoming WordPress 5.4 release. It would be good if someone else could confirm this. |
@aduth is there a download link for the 5.4 RC1? I was having trouble finding it. Edit: ah it was under https://wordpress.org/wordpress-5.4-RC1.zip |
@aduth I think 5.4-RC1 should be okay with Edge 18 |
It looks like the browser version is v44 (but EdgeHTML v18) in those screenshots, so I've changed the title to match. |
😩 Oh, the IE tax. Given that Microsoft has released a Chromium based edge, and is not only actively rolling pushing it out to Windows machines running classic Edge, but replacing the classic Edge too (updating the shortcuts to point the the new edge and disabling the classic Edge), I would say that the immediate next step is to remove any Edge related CSS code, especially if it's causing these issues. The original gallery margin issue that it fixed is not only Classic-Edge specific, but it's not fundamentally a breaking issue, and given classic Edge is actively being deprecated, it seems time to relieve ourself of that hack. |
Describe the bug
Accessing the block editor when using Gutenberg 7.6 on MS Edge 18 results in a blocking error that prevents users from editing or creating post and pages.
The issue seems to be specific to Gutenberg 7.6 and MS Edge 18, since it is not present when using either MS Edge 80 or Gutenberg 7.5
To reproduce
Alternative steps:
Expected behavior
The editor should load successfully.
Desktop (please complete the following information):
The text was updated successfully, but these errors were encountered: