Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table Block: Further distinguish headers/footers from regular cells #18767

Closed
melchoyce opened this issue Nov 26, 2019 · 7 comments · Fixed by #19450
Closed

Table Block: Further distinguish headers/footers from regular cells #18767

melchoyce opened this issue Nov 26, 2019 · 7 comments · Fixed by #19450
Assignees
Labels
[Block] Table Affects the Table Block Good First Issue An issue that's suitable for someone looking to contribute for the first time Needs Dev Ready for, and needs developer efforts [Status] In Progress Tracking issues with work in progress

Comments

@melchoyce
Copy link
Contributor

When I toggle on header/footer sections for headers, I'm expecting those rows to be more visually distinguished from regular cells, and maybe even have placeholder labels. True, the text becomes bold, but you wouldn't even know that until you click into a header cell and start typing. It needs to be more explicit, IMO.

@melchoyce melchoyce added Needs Design Needs design efforts. [Block] Table Affects the Table Block labels Nov 26, 2019
@talldan
Copy link
Contributor

talldan commented Dec 2, 2019

The original PR had some discussion on this (right from the start of the conversation) - #15409.

I think the bold text just comes from the theme styling, so that might not be guaranteed.

@shaunandrews
Copy link
Contributor

Placeholders could help a lot, and adding a simple 2px border below the header and above the footer also help. Here's a mockup of what that could look like:

image

@melchoyce
Copy link
Contributor Author

That helps a lot!

@melchoyce melchoyce added Needs Dev Ready for, and needs developer efforts and removed Needs Design Needs design efforts. labels Dec 4, 2019
@talldan talldan added the Good First Issue An issue that's suitable for someone looking to contribute for the first time label Dec 5, 2019
@dmahendrakar
Copy link
Contributor

Can I pick this up? It will be my first contribution to WordPress

@shaunandrews
Copy link
Contributor

@dpkm95 That'd be awesome!

@dmahendrakar
Copy link
Contributor

@shaunandrews I see there are no failing tests after after my change. Do you need me to add a snapshot test for table component? I see it's only added in block-library/embed. Is there any reason why snapshot tests are not added pervasively?

@aduth
Copy link
Member

aduth commented Dec 13, 2019

@dpkm95 Right now there's no visual snapshot tests. The snapshot tests you see in the code will test against the rendered output of a component. Since your changes only impact CSS, it would not be tested. Visual snapshot testing may be added in the future, but in the meantime, a visual verification of those changes should be sufficient for review.

@talldan talldan added the [Status] In Progress Tracking issues with work in progress label Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Table Affects the Table Block Good First Issue An issue that's suitable for someone looking to contribute for the first time Needs Dev Ready for, and needs developer efforts [Status] In Progress Tracking issues with work in progress
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants